search

HelgeGehring / femwell

FEM mode solver for photonic waveguides
https://helgegehring.github.io/femwell/
GNU General Public License v3.0
104 stars 30 forks source link

Add images to RF waveguide tutorial #166

Open duarte-jfs opened 3 months ago

duarte-jfs commented 3 months ago

Added images to the gitignore file

HelgeGehring commented 3 months ago

You don't need to add them to the gitignore, once something is added (you can still add ignored files just with git add) it'll keep being tracked :) About the images, can we just post pictures of papers? Don't know if that's allowed :thinking:

simbilod commented 3 months ago

You don't need to add them to the gitignore, once something is added (you can still add ignored files just with git add) it'll keep being tracked :) About the images, can we just post pictures of papers? Don't know if that's allowed 🤔

Typically there are links in articles to ask to reproduce figures. Depending on the journal and where you want to reuse the material, it may be free or cost something.

duarte-jfs commented 1 month ago

Apologies. I will close this pull request and create new ones, one for each topic.

EDIT: Reverted the commit on the meshing.

HelgeGehring commented 1 month ago

Thanks for the new PR!

How do we go on with this? Should we do our own pictures? Or does the journal have clear rules on reproducing pictures?

duarte-jfs commented 1 month ago

I say we just remove the figure and don't take any chances. It's not crucial to have the figure, and later we compare with data extracted from the paper

HelgeGehring commented 1 month ago

Looks good! The four remaining pictures you made yourself?

Did you by chance make them using some vector graphic tool (e.g. inkscape) and could upload them as a svg file? That way the pictures would be adjustable just like the rest of the docs (and the files also smaller :) )

HelgeGehring commented 2 days ago

Hey, we can also just remove those pictures and refer to the paper :)