search

HelgeGehring / femwell

FEM mode solver for photonic waveguides
https://helgegehring.github.io/femwell/
GNU General Public License v3.0
112 stars 33 forks source link

pyproject.toml is missing build-backend #73

Closed Sinbiosis closed 1 year ago

Sinbiosis commented 1 year ago

The Issue: I'm trying to build 0.1.5 inside of gentoo and the pyproject.toml is missing a 'build-backend', making it difficult to determine what build system to use for this repo.

Here is the reported error from the gentoo build system. Compiling source in /var/tmp/portage/dev-python/femwell-0.1.5/work/femwell-0.1.5 ... python3_11: running distutils-r1_run_phase distutils-r1_python_compile ERROR: dev-python/femwell-0.1.5::localrepo failed (compile phase): Unable to obtain build-backend from pyproject.toml

HelgeGehring commented 1 year ago

I addressed this in bdac0de, once the CICD runs through, I'll do a new release

Thanks for reporting!

HelgeGehring commented 1 year ago

Can you try again?

Sinbiosis commented 1 year ago

Just updated to 0.1.6 and while the package does build, it seems like it's not adding any useful files, other than metadata and documentation. Here is the list of files that will be installed before adding in the docs: image

Here is the list of files that are installed: image

Sinbiosis commented 1 year ago

I did not mean to close the issue

Sinbiosis commented 1 year ago

This package is currently missing a setup.py within the main branch that would build the package when using a setuptools build backend. I'm not sure how the wheel in https://pypi.org/project/femwell is built, but some documentation that shows how to build or a setup.py (and any needed associated files) that does the build would be helpful toward compiling from source.

HelgeGehring commented 1 year ago

The wheel is built using cicd, https://github.com/HelgeGehring/femwell/blob/main/.github/workflows/release.yml on my end installing it in "dev-mode" via pip install -e . also works

what exact command do you use to install?

HelgeGehring commented 1 year ago

Okay, I now reproduced the error and fixed it in bdb9f0188f561136d2a3df3d458ba6d01a1aa22c (at least on my side) - it seems that if I use poetry as a build-backend it works just fine. Could you confirm it also works for you?

HelgeGehring commented 1 year ago

@Sinbiosis is it now working for you? I think I can close this issue?