HelheimLabs / autochessia

Fully on-chain auto chess, built with MUD
https://dev.autochessia.xyz
GNU Affero General Public License v3.0
21 stars 14 forks source link

upgrade(cli): MUD Version 2.0.0-next.8 #182

Closed aLIEzsss4 closed 1 year ago

github-actions[bot] commented 1 year ago

Deploy preview for vercel-autochessia ready!

✅ Preview https://vercel-autochessia-m7o1gpe93-aliez.vercel.app

Built with commit b56629d54c961305bc2f8e2735009713b3771030. This pull request is being automatically deployed with vercel-action

aLIEzsss4 commented 1 year ago

The contracts have been split for now, further optimization is needed.

noyyyy commented 1 year ago

image https://discord.com/channels/865335009915961364/1151938472131694745/1152120768310820895

aLIEzsss4 commented 1 year ago

This MUD upgrade includes development versions of forge-std and ds-test dependencies. I think we should synchronize with them.

https://github.com/latticexyz/mud/blob/5150544354816949ab3d47950df7fc67ded797a7/examples/minimal/packages/contracts/package.json#L27

or

forge-std/=lib/forge-std/src/
ds-test/=lib/ds-test/src/
@latticexyz/=node_modules/@latticexyz/
@openzeppelin-contracts=lib/openzeppelin-contracts/contracts
cement/=lib/cement/contracts/
noyyyy commented 1 year ago

This MUD upgrade includes development versions of forge-std and ds-test dependencies. I think we should synchronize with them.

https://github.com/latticexyz/mud/blob/5150544354816949ab3d47950df7fc67ded797a7/examples/minimal/packages/contracts/package.json#L27

or

forge-std/=lib/forge-std/src/
ds-test/=lib/ds-test/src/
@latticexyz/=node_modules/@latticexyz/
@openzeppelin-contracts=lib/openzeppelin-contracts/contracts
cement/=lib/cement/contracts/

If you use ssh clone. It will generate lock which cannot be used directly in github action.

If you have used foundry, foundry project mainly use forge install to generate git submodule. By using submodule, you can also assign a commit hash.

Also the forge-std and ds-test are not maintained by lattice. Their api is stable. It usually doesn't matter if you use a different newer version.

aLIEzsss4 commented 1 year ago

This MUD upgrade includes development versions of forge-std and ds-test dependencies. I think we should synchronize with them. https://github.com/latticexyz/mud/blob/5150544354816949ab3d47950df7fc67ded797a7/examples/minimal/packages/contracts/package.json#L27 or

forge-std/=lib/forge-std/src/
ds-test/=lib/ds-test/src/
@latticexyz/=node_modules/@latticexyz/
@openzeppelin-contracts=lib/openzeppelin-contracts/contracts
cement/=lib/cement/contracts/

If you use ssh clone. It will generate lock which cannot be used directly in github action.

If you have used foundry, foundry project mainly use forge install to generate git submodule. By using submodule, you can also assign a commit hash.

Also the forge-std and ds-test are not maintained by lattice. Their api is stable. It usually doesn't matter if you use a different newer version.

fix

aLIEzsss4 commented 1 year ago

I will modify indexer things in another pr. Discard these to avoid conflict.

fix

noyyyy commented 1 year ago

Let's work together when you're free @aLIEzsss4. We need another indexer change pr to be merged at the same time

noyyyy commented 1 year ago

See #184, but it's wip.