HelheimLabs / autochessia

Fully on-chain auto chess, built with MUD
https://dev.autochessia.xyz
GNU Affero General Public License v3.0
21 stars 14 forks source link

Feat: Room is full starting automatically #40

Closed aLIEzsss4 closed 1 year ago

aLIEzsss4 commented 1 year ago

To ensure a smooth experience during matchmaking, there should be an auto-start mechanism once the room is full. For gas fees, if the game starts automatically, the last person to join the room should cover the gas cost. If the room owner manually starts the game, they should pay the gas fee.

github-actions[bot] commented 1 year ago

Deploy preview for vercel-autochessia ready!

✅ Preview https://vercel-autochessia-fs3d3ipxb-aliez.vercel.app

Built with commit bcc4746aaef4ef9c798bd0b0928db5e4ade53bdc. This pull request is being automatically deployed with vercel-action

ClaudeZsb commented 1 year ago

To ensure a smooth experience during matchmaking, there should be an auto-start mechanism once the room is full. For gas fees, if the game starts automatically, the last person to join the room should cover the gas cost. If the room owner manually starts the game, they should pay the gas fee.

But you did not explain the reason for that the one who pays the gas for starting a game should be the last player instead of the room creator. Since the room creator has already taken the burden of creating a waiting room, I recommend that the additional gas used for starting a game is paid by the room creator too. I think we would benefit from it in the future when we have a reimbursement mechanism.

aLIEzsss4 commented 1 year ago

To ensure a smooth experience during matchmaking, there should be an auto-start mechanism once the room is full. For gas fees, if the game starts automatically, the last person to join the room should cover the gas cost. If the room owner manually starts the game, they should pay the gas fee.

But you did not explain the reason for that the one who pays the gas for starting a game should be the last player instead of the room creator. Since the room creator has already taken the burden of creating a waiting room, I recommend that the additional gas used for starting a game is paid by the room creator too. I think we would benefit from it in the future when we have a reimbursement mechanism.

It would be ideal if the game could auto-start upon reaching max capacity and have the room owner cover the gas fees. The current solution we thought of is having the last player who joined pay for the gas when auto-starting. There may be better approaches to handle this