search

HelheimLabs / autochessia

Fully on-chain auto chess, built with MUD
https://dev.autochessia.xyz
GNU Affero General Public License v3.0
21 stars 14 forks source link

fix revert of underflow during tick #82

Closed ClaudeZsb closed 1 year ago

github-actions[bot] commented 1 year ago

Deploy preview for vercel-autochessia ready!

✅ Preview https://vercel-autochessia-68cw56nj9-aliez.vercel.app

Built with commit 07e77fab85cd52cf1e333a056a03db862feab5ef. This pull request is being automatically deployed with vercel-action

noyyyy commented 1 year ago

curious about how you fix this. Do you mock all hero location in test?

ClaudeZsb commented 1 year ago

curious about how you fix this. Do you mock all hero location in test?

There are still several logs in system contracts related to auto-battling. For example, here. When you run forge test -vv with a fork rpc, those logs work as well. It would help me determine that in which piece's turn the revert is produced.

noyyyy commented 1 year ago

curious about how you fix this. Do you mock all hero location in test?

There are still several logs in system contracts related to auto-battling. For example, here. When you run forge test -vv with a fork rpc, those logs work as well. It would help me determine that in which piece's turn the revert is produced.

Truely a good idea. Never thought this before.