search

Helidium / Mitol

Lightweight NodeJS http server
Other
175 stars 5 forks source link

no package.json #20

Open brandonros opened 6 years ago

brandonros commented 6 years ago

npm install https://github.com/Helidium/Mitol.git won't work because you don't have a package.json in the repo

Helidium commented 6 years ago

You are correct, currently you can install the package through npm install mitol. Although today later in the afternoon I will make a new release with included body parse fix.

On 16 April 2018 at 17:50, Brandon Ros notifications@github.com wrote:

npm install https://github.com/Helidium/Mitol.git won't work because you don't have a package.json in the repo

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Helidium/Mitol/issues/20, or mute the thread https://github.com/notifications/unsubscribe-auth/ABDmtBMjkaWdthsWYCdxrNaNuU7LdagSks5tpL2xgaJpZM4TWyxO .

brandonros commented 6 years ago

Are you also going to include a package.json in the repo?

Helidium commented 6 years ago

I can include the package.json, but I dont believe it will work as expected. because the root of the project is a C++ source code.

You can manually compile if you download all the sources, go into node folder, copy the root src folder into node folder and run the following: node-gyp rebuild > build_log.txt 2>&1 || exit 0

On 16 April 2018 at 18:12, Brandon Ros notifications@github.com wrote:

Are you also going to include a package.json in the repo?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Helidium/Mitol/issues/20#issuecomment-381660781, or mute the thread https://github.com/notifications/unsubscribe-auth/ABDmtGp2RdwDJ-KLo1PfjiNO5Mf4On8Bks5tpMMBgaJpZM4TWyxO .

brandonros commented 6 years ago

I'm working on a PR now. You are missing Makefile + binding.gyp in the repo as well.

Helidium commented 6 years ago

Its in the node folder...

On 16 April 2018 at 18:20, Brandon Ros notifications@github.com wrote:

I'm working on a PR now. You are missing Makefile + binding.gyp in the repo as well.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Helidium/Mitol/issues/20#issuecomment-381662921, or mute the thread https://github.com/notifications/unsubscribe-auth/ABDmtPpMvnvdiI1eC_ZxLxfFmjo9ZruHks5tpMS9gaJpZM4TWyxO .

Helidium commented 6 years ago

But you are correct it should be in the root. Thank you for your contributions Brandon :)

Regards,

On 16 April 2018 at 18:20, Marko Biskup helidium@gmail.com wrote:

Its in the node folder...

On 16 April 2018 at 18:20, Brandon Ros notifications@github.com wrote:

I'm working on a PR now. You are missing Makefile + binding.gyp in the repo as well.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Helidium/Mitol/issues/20#issuecomment-381662921, or mute the thread https://github.com/notifications/unsubscribe-auth/ABDmtPpMvnvdiI1eC_ZxLxfFmjo9ZruHks5tpMS9gaJpZM4TWyxO .