search

HelinWei-NOAA / ccpp-physics

GFS physics for CCPP
Other
0 stars 4 forks source link

using NoahMP tiled tq2m with the bug fix #53

Closed HelinWei-NOAA closed 1 year ago

barlage commented 2 years ago

@RongqianYang-NOAA @wzzheng90 in general, do we need a check for fh2 close to zero? or is that possible?

HelinWei-NOAA commented 2 years ago

https://github.com/ufs-community/ccpp-physics/pull/25

created for HR1

On Wed, Nov 30, 2022 at 4:55 PM Weizhong Zheng @.***> wrote:

@.**** commented on this pull request.

In physics/module_sf_noahmp_glacier.f90 https://github.com/HelinWei-NOAA/ccpp-physics/pull/53#discussion_r1036478512 :

@@ -1464,6 +1464,11 @@ subroutine glacier_flux (nsoil ,nsnow ,emg ,isnow ,df ,dzsnso ! 2m air temperature ehb2 = fv*vkc/(log((2.+z0h)/z0h)-fh2) cq2b = ehb2 +! for opt_sfc 3

  • if (opt_sfc ==3) then
  • ehb2 = fv*vkc/fh2

The stability becomes zero only under some conditions which we should avoid.

— Reply to this email directly, view it on GitHub https://github.com/HelinWei-NOAA/ccpp-physics/pull/53#discussion_r1036478512, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALPHKYFIJZVIMTAR7KA6Y3DWK7EK5ANCNFSM6AAAAAASQBG4Z4 . You are receiving this because you authored the thread.Message ID: @.***>