search

Helion-Engine / Helion

A modern fast paced Doom FPS engine
GNU General Public License v3.0
86 stars 9 forks source link

Improve IWAD search #572

Closed lemming104 closed 3 months ago

lemming104 commented 3 months ago

A couple attempts to improve IWAD detection for users who have multiple different Doom source ports on their machines and don't want to make multiple copies of their IWADs:

  1. On Windows, attempt to read the actual installed registry path for Steam, rather than just assuming it is in Program Files (x86). It is possible to install Steam to another path (I use C:\Steam on my own machine).

  2. Pass the contents of the "files.directories" element of the config file to the IWAD search method. I've verified that both absolute and relative (to current working directory) paths seem to work as expected. I don't know if that's what this config item was originally intended to do, so if this is wrong, I'll add a new config item instead (let me know).

nstlaurent commented 3 months ago

Using the files.directories config makes sense to me here. Just one small thing on the registry read, thanks!

lemming104 commented 3 months ago

Do you have unpublished comments on this PR? I'm unsure what you'd like me to change. :)

nstlaurent commented 3 months ago

Do you have unpublished comments on this PR? I'm unsure what you'd like me to change. :)

Sorry, I'm used to using another service and I don't have to do this final submit review step like here!