Helion-Engine / Helion

A modern fast paced Doom FPS engine
GNU General Public License v3.0
86 stars 9 forks source link

Regression: switches no longer work in KDIKDIZD #577

Closed lemming104 closed 2 months ago

lemming104 commented 3 months ago

This is a recent regression and was introduced in the last day or two (we are at commit 504fc4d as of this writing). I have not bisected to find the commit responsible, but I can do so if needed.

In KDIKDIZD (https://www.doomworld.com/idgames/levels/doom2/megawads/kdikdizd), some of the switches no longer work.

Repro steps: Load the PWADs in that archive on top of a Doom2 IWAD, and start a new game on any difficulty setting. Wander through the various open doors, until you come to a switch (coordinates shown in screenshot below).

Expected: Activating the switch should open a nearby door. You should also see the door opening on a security camera view next to the switch. Actual: The door does not open.

The switch (coordinates in upper right): helion_20240523_09 24 32 5917

The door it is supposed to open: helion_20240523_09 24 42 2613

nstlaurent commented 3 months ago

Looking into this showed that infinitely tall things wasn't being set from the complvl lump setting vanilla. For some reason the changes introduced require this to be set for KDIKDIZD scripts to work when it wasn't required before. I fixed setting infinitely tall things with the vanilla complvl which fixes this issue. I'm still going to dig some more to see why the physics are working differently here with infinitely tall things off.

nstlaurent commented 2 months ago

Fixed with 0.9.3.0