search

Helion-Engine / Helion

A modern fast paced Doom FPS engine
GNU General Public License v3.0
116 stars 10 forks source link

Crash when switching music sources #777

Closed lemming104 closed 1 month ago

lemming104 commented 1 month ago

Not sure what the preconditions are to hit this; might need to mess with it a bit. Encountered this when switching from FluidSynth to OPL3, listening to OPL3 for a while, then switching back. Suspect there might be some race condition where I am closing the stream on the ZMusic end before the audio stream stops polling for more buffers.

Application: Helion.exe
CoreCLR Version: 8.0.824.36612
.NET Version: 8.0.8
Description: The process was terminated due to an unhandled exception.
Exception Info: System.AccessViolationException: Attempted to read or write protected memory. This is often an indication that other memory is corrupt.
Stack:
   at ZMusicWrapper.ZMusicPlayer.IsPlayingImpl()
   at ZMusicWrapper.ZMusicPlayer.FillStreamFromFloatSource(Int16[])
   at Helion.Client.Music.AudioStream.PollingLoop(System.Threading.CancellationToken)
   at Helion.Client.Music.AudioStream+<>c__DisplayClass29_0.<Play>b__1()
   at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(System.Threading.Thread, System.Threading.ExecutionContext, System.Threading.ContextCallback, System.Object)
   at System.Threading.Tasks.Task.ExecuteWithThreadLocal(System.Threading.Tasks.Task ByRef, System.Threading.Thread)
   at System.Threading.ThreadPoolWorkQueue.Dispatch()
   at System.Threading.PortableThreadPool+WorkerThread.WorkerThreadStart()
lemming104 commented 1 month ago

Hopefully fixed by 0c959e8d6566a4fb9d4dd52533789526664a286e