HeliosVirtualCockpit / Helios

Helios Distribution
https://github.com/HeliosVirtualCockpit/Helios/wiki
GNU General Public License v3.0
199 stars 34 forks source link

ABRIS brightness mismatch when exporting viewport with patched name #431

Open L-Mustang opened 3 years ago

L-Mustang commented 3 years ago

If the ABRIS viewport is exported using patches, i.e. with a different name, then the brightness rotary knob's value will not correctly map to the actual brightness of the device in the 3D view.

Attached are two profiles. One profile (lordmustang_ka_50.hpf) uses an ABRIS viewport with a patched name. This viewport can be exported to the combined monitor setup. The other profile (lordmustang_ka_50_vanilla.hpf) uses the Ka50 Unmodified ABRIS viewport that doesn't require patches.

WTR:

Correct functionality:

  1. Apply lordmustang_ka_50_vanilla.hpf to DCS (make sure to revert any already installed viewport patches for the Ka-50)
  2. Start instant action in the Ka-50
  3. Check ABRIS brightness between exported viewport and device in 3D view
  4. Lower the brightness all the way using the rotary knob
  5. Check ABRIS brightness between exported viewport and device in 3D view
  6. Notice that brightnesses between the two renders match

Matching brightness: 20210716032608_1 20210716032612_1 20210716032550_1

Incorrect functionality:

  1. Apply lordmustang_ka_50.hpf to DCS
  2. Make sure to apply viewport patches
  3. Start instant action in the Ka-50
  4. Lower the brightness all the way using the rotary knob
  5. Check ABRIS brightness between exported viewport and device in 3D view
  6. Notice that brightnesses between the two renders does not match. In the exported view, brightness will fully decrease.

Mismatched brightness: 20210716033552_1 20210716033558_1 20210716033602_1

Profiles.zip

derammo commented 3 years ago

Awesome reporting, thanks! If more users took this much care, this would actually be fun.

Technical notes: This comes down to whether the viewport patches for Ka-50 break something in the Lua. I will repro and update accordingly. Note that the base line of this test should no be "reverted patches" but "run DCS repair (slow)" to make sure it is clean. So there are three relevant states: clean, reverted, and patched.

derammo commented 3 years ago

this is real weird... there isn't any damage done by the patches, so there must be something else going on. Needs more testing by devs to figure out if maybe it does something hard coded based on the name of the viewport. This will be easy to test by just creating monitor setups with the original name versus the new name and hand editing the Lua.