Helioviewer-Project / JHelioviewer-SWHV

Space Weather JHelioviewer ☉
https://swhv.oma.be
Mozilla Public License 2.0
49 stars 16 forks source link

IAS/GOES in jhelioviewer #230

Closed helioshk closed 1 year ago

helioshk commented 1 year ago

I noticed that GOES images are available on the helioviewer.org website, but not in jhelioviewer. Could the GOES images on the IAS server be made available in JHV too?

They are available on the ROB server, but it seems to have issues right now (Connection refused)

bogdanni commented 1 year ago

ROB server restored.

bogdanni commented 1 year ago

This was happening due to an inconsistent platform name between servers: GOES at ROB, GOES-R for the rest. This was corrected on ROB server and JHV was updated, please use the build from http://swhv.oma.be/download_test/

helioshk commented 1 year ago

Thanks! ROB is working again, but on the other servers it's producing errors:

Error encountered during JPX creation: Error creating JPX file
COMMAND:
PATH="" /usr/local/bin/kdu_merge -s /dev/stdin
ARGUMENTS:
-i /var/www/jp2/SUVI/2023/03/28/304/2023_03_28__14_16_00__GOES-R_GOES-R_Series_Solar_Ultraviolet_Imager_(SUVI)_SUVI_304.jp2,/var/www/jp2/SUVI/2023/03/28/304/2023_03_28__14_44_00__GOES-R_GOES-R_Series_Solar_Ultraviolet_Imager_(SUVI)_SUVI_304.jp2,
[snip...]
/var/www/jp2/SUVI/2023/03/29/304/2023_03_29__17_12_00__GOES-R_GOES-R_Series_Solar_Ultraviolet_Imager_(SUVI)_SUVI_304.jp2,/var/www/jp2/SUVI/2023/03/29/304/2023_03_29__17_44_00__GOES-R_GOES-R_Series_Solar_Ultraviolet_Imager_(SUVI)_SUVI_304.jp2 -links -o /var/www/jp2/movies/GOES-R_SUVI_304_F2023-03-28T14.12.21Z_T2023-03-30T16.06.20ZB1871L.jpx
RETURN VALUE: 3
OUTPUT:
bogdanni commented 1 year ago

That's a matter for those servers to fix: the image files were ingested in the database, but they are not available to create the movie to be streamed (most likely).

ebuchlin commented 1 year ago

Yes, I have also seen this error. I don't understand it, as we have the SUVI files corresponding to the error I got, and we can get the JPX for SDO/AIA or for the new SO/EUI dataset.

bogdanni commented 1 year ago

You may try to copy-paste the command in a shell on the server and investigate what goes wrong.

ebuchlin commented 1 year ago

Our issue is because of the parentheses in the file names, such as 2023_03_29__17_12_00__GOES-R_GOES-R_Series_Solar_Ultraviolet_Imager_(SUVI)_SUVI_304.jp2. Our kdu_merge on the command line works, but only if we add quotes or escape the parentheses. How is this working on the ROB and GSFC Beta servers?

bogdanni commented 1 year ago

The actual command to try is something like echo '-i /var/www/jp2/SUVI/... -links -o /var/www/jp2/movies/...' | /usr/local/bin/kdu_merge -s /dev/stdin

I think somebody from NASA modified my code "for security reasons" to add a check on allowed characters. Maybe the solution is to add '(' and ')'.

bogdanni commented 1 year ago

This commit is nonsense, IMHO.

helioshk commented 1 year ago

escapeshellcmd() ?

bogdanni commented 1 year ago

Those are files already on the secure server and their names are piped over the standard input to the 'kdu_merge' program on the same server, no shell involved. I don't get it.

bogdanni commented 1 year ago

Filed https://github.com/Helioviewer-Project/api/pull/278.

helioshk commented 1 year ago

I'm not sure where to leave this, but ROB doesn't have new GOES/SUVI images since March 30 12:00

bogdanni commented 1 year ago

Thanks, we'll look into it.

bogdanni commented 1 year ago

Processing was restored today. It started failing when I renamed the platform to GOES-R. Other servers should be unaffected. The gap since March 30 will be filled in the next couple of weeks.