search

Helioviewer-Project / helioviewer.org

Main web application for solar data visualization
Other
19 stars 15 forks source link

Helioviewer sometimes sends out of bound requests #371

Open dgarciabriseno opened 2 years ago

dgarciabriseno commented 2 years ago

Similar to #370, but more general. The front end made a getTile request with x=-1, y=1 where the maximum y should have been 0. y1 results in an out of bound request.

API Request:

api.helioviewer.org/?action=getTile&id=103905368&imageScale=2.42044088&x=-1&y=1&difference=0&diffCount=60&diffTime=1&baseDiffTime=2022-07-11T05%3A58%3A19.000Z

Readable query string parameters:

'action' => getTile
'id' => 103905368
'imageScale' => 2.42044088
'x' => -1
'y' => 1
'difference' => 0
'diffCount' => 60
'diffTime' => 1
'baseDiffTime' => 2022-07-11T05:58:19.000Z

This results in region:

{top, left},{width, height} Using values from 0 to 1.
{1.0081,0},{0,0.5} Computed value

Notice the "top" is out of bounds since the max should be 1, and the width is 0. This results an error trying to process it.

dgarciabriseno commented 1 year ago

Need to check if this was happening before the mobile UI/pinch zoom updates