search

Helioviewer-Project / helioviewer.org

Main web application for solar data visualization
Other
18 stars 15 forks source link

From phone can't move the Earth scale box or it doesn't include it when take screenshot #431

Closed Anthrwpos closed 1 year ago

Anthrwpos commented 1 year ago

Hi, I noticed that I can't move the Earth box and when I take screenshot the it doesn't include the box of Earth. From phone. Thanks

Anthrwpos commented 1 year ago

Hi, is there any update about the question? Thanks

wafels commented 1 year ago

Keeping the Earth box in one place while on mobile devices is by design, but it should appear in a screenshot. Which type of phone are you using?

Anthrwpos commented 1 year ago

When I take a screenshot from the option the page gives the box with the earth does not appear, only if I take a screenshot with the mobile mode it appears.

From: Jack Ireland @.> Sent: Thursday, February 9, 2023 8:05:05 PM To: Helioviewer-Project/helioviewer.org @.> Cc: Anthrwpos @.>; Author @.> Subject: Re: [Helioviewer-Project/helioviewer.org] From phone can't move the Earth scale box or it doesn't include it when take screenshot (Issue #431)

Keeping the Earth box in one place while on mobile devices is by design, but it should appear in a screenshot. Which type of phone are you using?

— Reply to this email directly, view it on GitHubhttps://github.com/Helioviewer-Project/helioviewer.org/issues/431#issuecomment-1424606617, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AE6JIU6KOTISCJKI2QH7JTTWWUWVDANCNFSM6AAAAAAUBQ2O6U. You are receiving this because you authored the thread.Message ID: @.***>

Anthrwpos commented 1 year ago

Οκ, but why is it by design that the box does not move from view to mobile?

Anthrwpos commented 1 year ago

No, in screenshot ( from the option of the website) doesn't appear the icon of Earth. why? but with a screenshot when I do it from the mobile phone, the Earth is visible.

Anthrwpos commented 1 year ago

Can the design be changed so we can move the box with the Earth? Thanks

dgarciabriseno commented 1 year ago

Yes, I can work on this now.

The other issue I see here is that the earth scale will appear in screenshots, but only when the viewport is in the right spot. The problem that needs to be fixed is the position of the earth scale widget you see in the mobile view is different than the position used when a screenshot is taken, and that's a problem that I need to fix.

Once I fix that I'll look into making it moveable.

dgarciabriseno commented 1 year ago

The earth scale box can now be moved. Fixed in 77a0f9a839c3760ce907c272a97978c4d30e5fdb

The position of the earth scale box in the viewport is now mostly aligned with what you see in a screenshot. There is a slight offset, but hopefully this isn't too much of an issue. Positioning fixed in 4843f07702373a3503f6cb895f3d4f91658ef4b8