search

Helioviewer-Project / helioviewer.org

Main web application for solar data visualization
Other
18 stars 15 forks source link

Selected HEK features/events not showing up in the mobile client #458

Closed wafels closed 1 year ago

wafels commented 1 year ago

Selected HEK features/events do not show up on the mobile client. However, selected CCMC results are displayed. The expected behavior is that the HEK features/events should be displayed.

The browser used was Safari on an iPhone.

wafels commented 1 year ago

Also, the HEK "check all" and "check none" buttons do not work.

btaylor-sesda commented 1 year ago

@wafels This looks to be from the CCMC project that @dgarciabriseno is currently working on.

https://github.com/Helioviewer-Project/helioviewer.org/commit/d354f7d4fc1e424dfd26615fcff4314459e41887

The "Loading Data" keeps spinning now, none of the non-CCMC pins are working on HEK, and none of the tools in the top right tray are clickable.

The console error says, "properties of undefined (reading 'concat')". It mentions that it has a problem with this line 123 from resources/js/Events/EventTree.js

saved = self.getSavedEventLayers().concat(this._selectedEventCache.get());

dangarbri commented 1 year ago

Hey @btaylor-sesda thanks for triaging this. I'm not seeing the error myself so I'll need your help. Let's talk

dgarciabriseno commented 1 year ago

The features/events not working is mobile specific. I'll look into it once we fix #407

dgarciabriseno commented 1 year ago

Loading issue fixed, now looking into these checkboxes

dgarciabriseno commented 1 year ago

This might actually have had the same root cause as the "loading data" issue. It appears to be working for me on my own phone and several phones on browserstack

wafels commented 1 year ago

Works on Safari / iPhone . Closing.