search

Helioviewer-Project / python-api

Python wrapper around the Helioviewer API.
https://hvpy.readthedocs.io/en/latest/
BSD 2-Clause "Simplified" License
6 stars 5 forks source link

Adds `createMovie` function to generate movie #73

Closed akash5100 closed 1 year ago

akash5100 commented 1 year ago
codecov-commenter commented 1 year ago

Codecov Report

Base: 99.53% // Head: 99.41% // Decreases project coverage by -0.12% :warning:

Coverage data is based on head (ceb22c8) compared to base (ccc80c3). Patch coverage: 97.22% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #73 +/- ## ========================================== - Coverage 99.53% 99.41% -0.13% ========================================== Files 24 25 +1 Lines 647 682 +35 ========================================== + Hits 644 678 +34 - Misses 3 4 +1 ``` | [Impacted Files](https://codecov.io/gh/Helioviewer-Project/python-api/pull/73?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Helioviewer-Project) | Coverage Δ | | |---|---|---| | [hvpy/helpers.py](https://codecov.io/gh/Helioviewer-Project/python-api/pull/73/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Helioviewer-Project#diff-aHZweS9oZWxwZXJzLnB5) | `97.14% <97.14%> (ø)` | | | [hvpy/utils.py](https://codecov.io/gh/Helioviewer-Project/python-api/pull/73/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Helioviewer-Project#diff-aHZweS91dGlscy5weQ==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Helioviewer-Project). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Helioviewer-Project)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

nabobalis commented 1 year ago

2022-08-20T11:42:06.641586_2022-08-20T11:47:06.641586.mp4 is also too verbose of a filename. We need to work out something better.

akash5100 commented 1 year ago

2022-08-20T11:42:06.641586_2022-08-20T11:47:06.641586.mp4 is also too verbose of a filename. We need to work out something better.

Is only the date reasonable? eg: 2022-08-20_2022-08-21.mp4

nabobalis commented 1 year ago

2022-08-20T11:42:06.641586_2022-08-20T11:47:06.641586.mp4 is also too verbose of a filename. We need to work out something better.

Is only the date reasonable? eg: 2022-08-20_2022-08-21.mp4

I think there needs to be more information.

nabobalis commented 1 year ago

So in theory the screenshot version will look like this PR.