search

Helioviewer-Project / python-api

Python wrapper around the Helioviewer API.
https://hvpy.readthedocs.io/en/latest/
BSD 2-Clause "Simplified" License
6 stars 5 forks source link

`save_file` now cleans the filename, expands user and returns the full file path #84

Closed nabobalis closed 1 year ago

nabobalis commented 1 year ago

Fixes https://github.com/Helioviewer-Project/python-api/issues/83 Cleans filename, expands users and returns the filename now.

We also forgot to delete the old changelog file and point users to where the "changelogs" are kept.

nabobalis commented 1 year ago

I would like to get a 1.0.1 out of the door with this PR.

codecov-commenter commented 1 year ago

Codecov Report

Base: 99.29% // Head: 99.30% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (e7b1d8c) compared to base (716a5ec). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #84 +/- ## ======================================= Coverage 99.29% 99.30% ======================================= Files 25 25 Lines 711 716 +5 ======================================= + Hits 706 711 +5 Misses 5 5 ``` | [Impacted Files](https://codecov.io/gh/Helioviewer-Project/python-api/pull/84?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Helioviewer-Project) | Coverage Δ | | |---|---|---| | [hvpy/helpers.py](https://codecov.io/gh/Helioviewer-Project/python-api/pull/84/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Helioviewer-Project#diff-aHZweS9oZWxwZXJzLnB5) | `96.15% <100.00%> (ø)` | | | [hvpy/utils.py](https://codecov.io/gh/Helioviewer-Project/python-api/pull/84/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Helioviewer-Project#diff-aHZweS91dGlscy5weQ==) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Helioviewer-Project). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Helioviewer-Project)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.