search

Helium314 / HeliBoard

Customizable and privacy-conscious open-source keyboard
Apache License 2.0
2.45k stars 97 forks source link

Add tab key to toolbar #1001

Open deveee opened 3 months ago

deveee commented 3 months ago

There are already up/down/left/right arrows. It would be useful to also add tab key, so it can be used to autocomplete commands in terminal or just switch between input fields.

I can add it in custom layout but toolbar would be better because there is free space there and it's less probable that I would accidentally touch it during typing text.

Actually I miss also "ctrl" button to be 100% happy.

Or maybe add "full keyboard" layout in landscape mode like in hacker's keyboard.

deveee commented 3 months ago

The tab key seems simple enough https://github.com/deveee/HeliBoard/commit/b924e3bf1f884784299d046df0bbb7861a4f5294

Not sure if you are interested in it.

Note that I had to reset toolbar layout to make it visible in settings.

devycarol commented 3 months ago

I'd hate to see that toolbar config get too daunting (I say this as the person whose made a fifth of those keys and counting...)

I think this is a good idea, and converting existing keys to toolbar ones is trivial. I just wonder if there'll be a way to maintain/improve the approachability of the toolbar config as these keys pile up. Visible categories (navigation, editing, etc.) and improved drag-drop behavior are both ideas that come to mind.

Helium314 commented 3 months ago

I'm against adding normal keys to the toolbar list, as @devycarol mentioned there is already a large number of keys. And adding even more keys will make people want a completely re-worked screen to adjust toolbar keys, simply because there are too many keys for the current style (it's already too much imo).

Only thing I'd be ok with is (if it's reasonably simple!) is adding some sort of customitzable toolbar keys that allow you to define the key code.

devycarol commented 3 months ago

Oh yeah I 100% agree with "custom" key approach.

Helium314 commented 3 months ago

When only allowing a certain number of configurable keys, it should be reasonably simple to add such toolbar keys (just check key code in settings). The icon is an issue though. Here it would be helpful to first do the planned changes to KeyboardIconsSet (for decoupling from theme style, not sure where it was discussed).

devycarol commented 3 months ago

980 methinks.

Helium314 commented 3 months ago

That's it, thanks! I'll work on step 1 when I have some time (not before next week).