Helium314 / HeliBoard

Customizable and privacy-conscious open-source keyboard
Apache License 2.0
2.44k stars 97 forks source link

bring back diacritics and "unused" keys via settings option #1028

Open code-consensus opened 3 months ago

code-consensus commented 3 months ago

Hi there,

Release 2.2 removed diacritics and "unused" keys as per issue #921 and pull #659 .

In my opinion, this was a feature, not a bug. Actually, it was something I really liked about the keyboard.

Would it be possible to restore the original functionality of the app via a settings toggle?

E.g. it could be under Preferences / Additional Keys with something like "remove letters from popup keys not in the language of the locale". And that could be switched on by default for the new v2.2 behavior, and the user could deselect that to let the app function as v2.1 and before.

Thanks for an amazing app!

Uranusek commented 3 months ago

The "show more letters with diacritics in popup" option should solve your problem. It's in advanced settings.

FabiRich commented 3 months ago

Maybe a hint in the readme would be useful, because I couldn't find this setting either, only by looking into the issues on github. Or relocate the point to the options settings

BlackyHawky commented 3 months ago

...because I couldn't find this setting either

Look in the advanced settings.

FabiRich commented 3 months ago

Yes but only with the info of this issue.

code-consensus commented 3 months ago

@Uranusek thanks!! I had never noticed this under Advanced settings! Changing that to "Add very common variants" made the keyboard work as before.

The issue is "solved" in terms of the "problem", but there is then one lingering issue related to this -- that advanced setting is now mislabeled with v2.2. When you click there it lists the options in the following order:

But now the first option should be labelled default, not the second one.