Helium314 / HeliBoard

Customizable and privacy-conscious open-source keyboard
Apache License 2.0
2.47k stars 97 forks source link

Respect "do not disturb mode", "silence mode" or "battery saving mode" by stopping vibration #1125

Closed Massedil closed 1 month ago

Massedil commented 2 months ago

Hello and thanks for this great app.

Describe the bug

When I put my phone on "do not disturb mode", "silence mode" or "battery saving mode", the keyboard vibration stays active.

For now, keyboard sound is well stopped by :

Keyboard sound is active when "battery saving mode" is active (don't know if this is good behavior or not).

To Reproduce

Expected behavior

Vibrations stops (may be after a checkbox Stop vibrating if "do not disturb mode", "silence mode" or "battery saving mode" is active is checked in app parameters).

App version

2.2 from F-Droid

Device:

Helium314 commented 1 month ago

I understand this for do not disturb, but silent mode just disables the sound and not vibration. Or has this changed in recent Android versions?

As for battery saving mode: does vibration or sound have a noticeable or at least measurable effect on battery?

Edit: looks like silent mode did disable vibration only for a short time According to another article, vibration in silent mode can be disabled specifically. So I will not disable haptic feedback in silent mode.

Massedil commented 1 month ago

Exact, silence mode and battery saving mode let vibrations of the Android interface active (on my Android 14 / LOS21 phone), I agree with you. So only the do not disturb can be useful (my main need).

codokie commented 1 month ago

I'd argue that this change should be optional, the reasoning is that vibration feedback helps you type more accurately, and if the device has a decent vibrator, then each vibration is a light (not disturbing) sensation