Helium314 / HeliBoard

Customizable and privacy-conscious open-source keyboard
Apache License 2.0
2.45k stars 97 forks source link

Allow usage of key hints for keys that already exist as separate key (from layout alt keys and language keys) #1213

Open Quantom2 opened 5 hours ago

Quantom2 commented 5 hours ago

Allow usage of key hints for keys that already exist as separate key (maybe it is a bug but i didnt sure)

Solution: allow proper usage of doubling key hints Now keyboard didn't allow me to type any letter from language key box, or from layout bindings, if this letter already exysts as separate key. Heliboard even show me letter hint in right corner, but if hold button this letter just isn't in the list. Please, allow usage of multiple key bindings like this, 'cause it allow more freedom when didn't take anything from user.

Use case Something like doing now. I modifying keyboard layout, and added 'ї' letter as separate key. But, cause I didn't want to people make hard time re-learning layout, i wanna save old way of typing this letter - by holding 'i'. BUT it just didn't work. In this case, if this type of input were allowed, less people would be cinfused and/or type wrong letter by their muscule memory.

Pictures: Stock layout. Pay attention that 'ї' added as wariant of 'і' in local_key_texts зображення_2024-11-17_010854543

My new layout ('і' and 'ї' circled. Pay attention that on 'i' there are hint of 'ї') зображення_2024-11-17_005706019

When i hold 'i': зображення_2024-11-17_010954605 Pay attention that 'ї' still added as wariant of 'і' in local_key_texts.

!!!EDITED!!!

Set Remove redundant popups to OFF by default

Solution: set setting "remove redundant popups" to disabled state by default As described below, cases when people need this feature, seems to me wery, wery few, maybe when you need use overload by popups layout. But enabling this by default make it harder to people that need to have several popups in addition to already exysting key. So, i suggest make it off by default

Use case As already described upward and downward

BlackyHawky commented 5 hours ago

@Quantom2 You have to disable the Remove redundant popups setting in Preferences 😉 Don t forget to close this issue if it works properly.

Quantom2 commented 5 hours ago

Thanks, that's worked! Anyway, I'm consist not on closing, but on redacting issue, or (if it wont alowed) to close this and open new. I mean this cause i didn't understand why this option is ON by default, when it needed only in wery close cases, even more closest than mine layout changes... So... Maybe it should be OFF by default? Anyway, thanks for help!

Quantom2 commented 4 hours ago

I mean, i chill, no aggression (English isn't my native, so i thoughts now that might souded like this...), thank you for your advice, but cause i wanna return my fork with enhanced layouts to overall repo (not cause only i would benefit of it, there are weight reasons why my changes make owerall typing experience better in UK and RU too), i wanna to be sure it work properly, because for it it would be great if people still can be acsess old way of typing 'ї'

P.S. now here a 1 hr of midnight, so i will fully edit my issue with full proper explanation tomorrow, sorry

BlackyHawky commented 4 hours ago

Don't worry I've noticed there's no aggression in your comments 😉 I fully agree that this setting should be disabled by default. Maybe you can close this topic and open another one to ask that.

Quantom2 commented 4 hours ago

Will do this yesterday, and will wrote adecuate description why it's better to off by default 👌

Quantom2 commented 4 hours ago

Oh, and little one ask. Where i can change this settiong to off in source files? (Wanna make proper apk before my changes in layout (if will) be published as stable build