Helium314 / HeliBoard

Customizable and privacy-conscious open-source keyboard
Apache License 2.0
1.92k stars 68 forks source link

Words added to the wrong dictionary #578

Open markokocic opened 3 months ago

markokocic commented 3 months ago

Info My phone has German as a default language. HeliBoard has Serbian, German and English, option to add words to personal dictionary is enabled. Spellchecker is set to HeliBoard. Using the latest HeliBoard release from Github.

To Reproduce

  1. Click on some edit box to open keyboard
  2. Switch to the Serbian language
  3. Type a word that is not in a dictionary, it will be underlined in red
  4. Add a word to the dictionary.

Expected behavior The word should be added to the dictionary of the currently selected language, it this case Serbian. Alternatively, dialog should ask to which dictionary should add it

Actual behavior Word is added to the German dictionary.

App version Latest release from GitHub.

Proposed fix

  1. When adding word to personal dictionary, provide a drop down to choose which dictionary, at least for multilanguage keyboard
  2. Add word to the current dictionary (not sure what to do in case of multilanguage keyboard in this case)

Device (please complete the following information):

Helium314 commented 3 months ago

When adding word to personal dictionary, provide a drop down to choose which dictionary, at least for multilanguage keyboard

This is not possible, the menu when clicking an underlined word is coming from Android and not under control of HeliBoard. I'm not even sure whether HeliBoard is asked for the language in such a case, or the menu just selects the default (system) language

sander76 commented 3 weeks ago

For what it's worth: I was suffering from the same. The 'add to dictionary' was just not working. I decided to just disable it as it was an annoyance more than a help. I had to 'disable' the gboard app to get this done.