Helium314 / HeliBoard

Customizable and privacy-conscious open-source keyboard
Apache License 2.0
1.89k stars 67 forks source link

Black background not working when forcing dark mode #582

Open marvin1099 opened 3 months ago

marvin1099 commented 3 months ago

Describe the bug Keyboard buttons are unhappy about darker colors

To Reproduce Set color theme to black

Expected behavior Buttons should all have a black backround

Screenshots Screenshot_20240322-174039_Fennec

App version 1.0-alpha1

Device:

Additional Info If im exakt it even seems that some buttons are the darkest on Gray and after that they go Back to white (so complete black is white again), i found out about that when i tryed user-defined colors

Helium314 commented 3 months ago

I can't reproduce this. Did you change anything else in the appearance settings besides switching to black theme?

If im exakt it even seems that some buttons are the darkest on Gray and after that they go Back to white (so complete black is white again), i found out about that when i tryed user-defined colors

Sorry, I don't understand what you mean by that.

Btw next time please stick to this part of the issue template:

If you add screenshots, reduce the size or use thumbnails to keep the issue nicely readable

marvin1099 commented 3 months ago

Sorry i seam to habe missed that

If you add screenshots, reduce the size or use thumbnails to keep the issue nicely readable

Stange now the buttons seem to go black, I didnt change anything, bizarre. There ist still one button that is not following the black color. Here a Screenshot of the button, but this time with less hight so the it shold stay more readable Screenshot_20240323-101032_Fennec_1 That button seems to allways mix any color you give it, by changing the "keyboard background" color, with Gray, so black becomes dark gray and white becomes light Gray. The button that im talking about is the arrow on the left side of the picture.

Helium314 commented 3 months ago

You will be able to explicitly set that button's background at a later point, I didn't yet have time to implement it.

Good that it works now. Could you check when you change the theme again (e.g. to light), does it now have black backgrounds? There might be some issue with the keyboard not properly reloading after a color change (working correctly on my phone, LineageOS 16).

Once you swipe the keyboard settings away when switching apps, the app is closed completely and thus will do a full reload when it next shows. Maybe that's why it works now...

marvin1099 commented 3 months ago

The spacebar, the enter key and the 4 buttons when you long press comma seem to be affected. They seem to randomly go white, it dosn't seem to happen offen but still strange. Right now the buttons look fine but earlier that day they where white for a moment. No idea how that happens. I report back when i find some sort of trigger that makes these button backgrounds go white again.

Edit: I found the trigger, the buttons go white when i open a app that I have forced to darkmode with darkq, then these buttons go white until the app is restarted.

Edit edit: Nope now it dosn't happen anymore now strange, i still think is probably something about darkq.

Uranusek commented 3 months ago

I checked and it looks like it's not HeliBoard's fault. Forcing a dark theme in Android settings causes strange things. In my case, all the buttons turn white. So it's probably the same with DarQ. Check if forcing a dark theme in Android settings also causes this bug for you.

Changing the keyboard and going back to HeliBoard should reproduce this bug.

Uranusek commented 3 months ago

I turned off key borders and managed to reproduce the "bug". Screenshot_2024-03-23_21-42-51_1_1

The problem disappears after disabling dark theme enforcement in Android settings, so I'm pretty sure it's not HeliBoard's fault.

marvin1099 commented 3 months ago

Right, well at least the Problem has been found. I guess, the issue would be solved. Well the arrow on the top left still would be nice to have a color selection, but that is planed right, if so this can be closed, it probably wont make sence to ajust for dark theme enforcment mode.

Helium314 commented 3 months ago

Most colors work just fine, so would assume it's possible to make those keys also display correctly.

I think we can still leave the issue open, in case someone wants to try fixing it. (my phone can't force dark mode)

marvin1099 commented 3 months ago

OK then, shure if it still gets fixed it wouldn't hurt, also unrelated but your phone can probably force dark mode you just need the app darkq and follow the Instructions (its also explained on the webside), since you never mentioned the app, i wasnt shure how you think that it work (or maby your phone is locked down so hard that it dosn't work), would you say what is going on on you phone? I just thought i mention it in case it was unclear what i ment.

Helium314 commented 3 months ago

DarQ requires Android 10 according to description, so not working on my Android 9 phone.

marvin1099 commented 3 months ago

DarQ requires Android 10 according to description, so not working on my Android 9 phone.

Ohhh, makes sence

Uranusek commented 3 months ago

With the key border off it's not that bad, but if it's on it looks much worse. Screenshot_20240326-101611_1

KaKi87 commented 1 month ago

Hi, Any news on this ? Thanks