Hide expand button when all toolbar buttons are pinned

[Commenter25]

Is your feature request related to a problem? Please describe. All I need is select all and clipboard, which I pinned for efficiency. But in this case, there is now an arrow button which does nothing but show me that which was already there. This takes up space, causing more suggestion truncation.

Describe the solution you'd like When all enabled toolbar buttons are pinned, hide the expand button.

Use case For people who only need their pinned buttons.

Describe alternatives you've considered Just an option to toggle the button's visibility, rather than checking if all buttons are pinned.

Additional context

[codokie]

how do u propose to allow the user to remove a pinned key if the main toolbar is disabled due to all toolbar keys being pinned?

[Commenter25]

An excellent point I had not fully considered. Perhaps pinning should simply be put in the settings. It doesn't seem like something one would want to do often, and having it in the settings would be much more obvious than having to explain it in the hidden features text dump. This would also prevent conflict with the feature requests for actions when holding a key. Perhaps an extra button per item in the select toolbar keys menu, or even a separate menu for toggling pinning.

Of course, ultimately, I'd be happy with just a toggle to hide that button for a bit more screen real estate. Just giving my two cents on how to more intuitively implement this.

[codokie]

I think a setting to toggle the main toolbar (along with the visibility of the expand key) plus a dialog for choosing pinned keys should be a good solution. Maybe disable the long press toolbar pinning mechanism too and repurpose it for long press functions #686

[Helium314]

Perhaps pinning should simply be put in the settings. It doesn't seem like something one would want to do often

I intentionally kept the long-press pinning, as there was already some discussion or request where a user mentioned they are frequently using the toolbar key pin/unpin and didn't want it in the settings.

[Commenter25]

Suppose this is an instance of Hyrum's Law.

If we're accounting for the usecase of constantly pinning and unpinning things using the long press, it'd probably just be confusing to attempt to make hiding the expand button automatic. So, I'm out of more thought out ideas than "add a checkbox" :p

I still think a menu in the settings alongside the long press would be good for discoverability, and to rearrange without unpinning/repinning stuff. It's not really necessary though. All up to subjectivity, I think. Not really relevant to this issue, anymore at least.

[KaKi87]

Hi, Alternatively, I'd like to suggest adding a Pin all toolbar keys checkbox in settings, which, when checked, removes the expand button. Thanks

[codokie]

thanks to 388366c we can choose the pinned toolbar keys in the settings. It should be easier now to add a setting to hide the main toolbar and the expand toolbar key, but it might conflict with the recently merged #674