Helium314 / HeliBoard

Customizable and privacy-conscious open-source keyboard
Apache License 2.0
2.3k stars 89 forks source link

Extend existing superscript symbols on popup keys #902

Closed b02860de585071a2 closed 3 months ago

b02860de585071a2 commented 3 months ago

I have built and tested this on both an emulator and a physical Pixel 8 Pro, using standard EN-US QWERTY layout and Spanish QWERTY (with ñ, unsure of the technical name?).

Due to the minor nature of this change, I doubt it will introduce any complications, but further testing on lesser-used layouts is likely still needed.

Helium314 commented 3 months ago

I'm ok with the number row changes, but the other keys seem to be more suitable for symbols_shifted than for symbols, or at very least should not be the first popup.

b02860de585071a2 commented 3 months ago

the other keys seem to be more suitable for symbols_shifted than for symbols

is actually supposed to be in symbols_shifted, I just stuck it on the wrong key.

https://github.com/Helium314/HeliBoard/pull/902/commits/730d9e9314d99b7bfe7437947e029abc7e10bb07 should now preserve default popup key orders as shown below:

Current stable version screenshots ![Screenshot_20240629-191438_Nova Launcher](https://github.com/Helium314/HeliBoard/assets/96025485/570905c5-966f-43d5-b265-170e671ad5c7) ![Screenshot_20240629-191418_Nova Launcher](https://github.com/Helium314/HeliBoard/assets/96025485/31336039-f133-47e5-8257-81c9829a45ed) ![Screenshot_20240629-191406_Nova Launcher](https://github.com/Helium314/HeliBoard/assets/96025485/44cd04b4-cde3-41ec-bc82-1d4b0db61a88) ![Screenshot_20240629-191350_Nova Launcher](https://github.com/Helium314/HeliBoard/assets/96025485/f4fc6f71-d3b6-4c0c-80b7-c752b5e7d891) ![Screenshot_20240629-191335_Nova Launcher](https://github.com/Helium314/HeliBoard/assets/96025485/0f58cf24-59d8-40a4-b8b5-a73a7e6ae3bf)
730d9e9 screenshots ![Screenshot_20240629-191808_Nova Launcher](https://github.com/Helium314/HeliBoard/assets/96025485/cd48fc89-13dd-4015-bfd6-f812d3046149) ![Screenshot_20240629-191755_Nova Launcher](https://github.com/Helium314/HeliBoard/assets/96025485/d39d192c-e411-4f89-9f5a-beb26762162a) ![Screenshot_20240629-191736_Nova Launcher](https://github.com/Helium314/HeliBoard/assets/96025485/f0bb09fd-93b6-49e0-8390-1bf5dfc44d6e) ![Screenshot_20240629-191722_Nova Launcher](https://github.com/Helium314/HeliBoard/assets/96025485/bc45f056-88b5-46b5-b611-3277d917c63d) ![Screenshot_20240629-191706_Nova Launcher](https://github.com/Helium314/HeliBoard/assets/96025485/1d398952-e58e-4620-b6e2-f5c94c3dbdd4)

This also keeps the grouping much more consistent with defaults (paren is now on the outside of the other types of brackets, etc). Let me know your thoughts.

Helium314 commented 3 months ago

Thanks, this look fine.