search

Helium314 / HeliBoard

Customizable and privacy-conscious open-source keyboard
Apache License 2.0
2.3k stars 89 forks source link

Make incognito indicator optional #903

Closed ghost closed 3 months ago

ghost commented 3 months ago

Is your feature request related to a problem? Please describe.

I don't use features like spell checker, auto-correction, suggestions or dictionary, so I disabled all of these in keyboard settings and also checked "force incognito mode" ("stop learning new words").

The problem is that incognito indicator is always present with these settings and it's really annoying as it has the brightest icon on the default dark theme.

Describe the solution you'd like

New toolbar setting to make presence of this indicator optional. By default, it would be enabled (will fit to most of the users).

Describe alternatives you've considered (if any)

To try out other themes where incognito indicator is not so prominent. Didn't tried – I do reallly like the default one :).

I can enable "learning new words", but that's just workaround (enabling function which has no use-case for keyboard settings I use).

ghost commented 3 months ago

Did you try the custom colors, all colors?

I think tool_bar_expand_key does what you want.

Edit Typo fix

ghost commented 3 months ago

Thanks, didnt know about that. Tried that, but I had to reinstall heliboard after enabling custom colors :) – clipboard went fully blank, even though I set predefined theme back.

The thing with custom colors is, that I would have to set each color code manually, at least this is how it appear in newest beta release (starting with default gray color for each entry). It would be easier if custom palette start with an existing theme colors (for example, there would be theme picker to load color set), where only selected colors would be fine-tuned. But that's beta version and things can change in official release, so I will wait.

Helium314 commented 3 months ago

clipboard went fully blank, even though I set predefined theme back

Can you provide more information on this? Did you try swiping away the keyboard in recents? This fully closed the keyboard, so everything is reloaded next time it's opened.

The fully customizable colors certainly aren't user friendly, and I only made them available so people who absolutely want to tune some specific detail can do as they wish. I'd be ok with some reasonable defaults being added, but this must happen in a way so I don't need to consider or update those defaults when I add or remove a color.

As to your request: I will not add some "hidden incognito mode" option, this is getting too much nice even for my taste. If the icon is too bright for you, you can set custom colors and make the key text darker (icons use the same color). Since the icon is too bright by default, darker text also shouldn't be an issue.

You could also disable the force incognito setting if you can live with having recently used emojis stored. Since you already disabled other related settings it there shouldn't be much difference.

ghost commented 3 months ago

Can you provide more information on this? Did you try swiping away the keyboard in recents? This fully closed the keyboard, so everything is reloaded next time it's opened.

Yesterday (I guess), I have installed beta pre-release to check new features / fixes. Today I was trying to change colors as suggested so I entered custom colors and then tried advanced setting with all colors. I have tried some colors and when I was completely lost :D, I decided to set default dark theme, but later I noticed, that enter key's foreground color was gray (as default color in custom theme settings), and also whole layout of clipboard had solid gray color (looked blank), even toolbar buttons where not visible - it seemed as some of the colors of the default dark theme were overriden by custom theme colors. I tried to tap on toolbar, on places where buttons should be, but it did do nothing (im not sure about this, maybe action was triggered and I do not remember correctly).

You could also disable the force incognito setting if you can live with having recently used emojis stored. Since you already disabled other related settings it there shouldn't be much difference.

Thanks for the tip, I will disable "force the incognito" – didn't know according to description in what extent would be "learning new words" applied e.g. if it will enable all learning, including those one, that were disabled earlier (spellcheck, suggestions, ...). Actually this would be even better as I would get emoji history which I was using also in OpenBoard.