Helium314 / HeliBoard

Customizable and privacy-conscious open-source keyboard
Apache License 2.0
2.21k stars 84 forks source link

missing icon for uppercase button #943

Open zputnyq opened 2 months ago

zputnyq commented 2 months ago

Please see the appropriate readme section for issue reporting guidelines: https://github.com/Helium314/HeliBoard?tab=readme-ov-file#reporting-issues tl;dr:

Describe the bug missing icon for uppercase button, the icon will only appear when it is used for uppercasing all letters on a word (hold the button). It happens on v 2.0 & 2.1. On 1.3, it's normal. To Reproduce It will be invincible if similar device is used

Expected behavior The icon should be visible Screenshots Screenshot_20240704-020746

App version V 2.0 & V 2.1

Device:

Helium314 commented 2 months ago

Could you install the debug version below and provide a log after you see that the icon is missing? HeliBoard_2.1-debug.zip

zputnyq commented 2 months ago

Could you install the debug version below and provide a log after you see that the icon is missing? HeliBoard_2.1-debug.zip

Here are the logs, I took it twice. Numbered 1. I long press the uppercase button. Numbered 2 I did nothing. 1.txt

2.txt

Helium314 commented 2 months ago

So there is an icon set, and also the colors are set to KEY_ICON (when not shifted) and SHIFT_KEY_ICON (when shifted). KEY_ICON is the same color as used for e.g. the delete key. It almost seems like your phone is not reading the icon correctly.

Can you check whether the issue is the same for rounded and holo themes? Oh, and do you see icons for all entries when you go to settings -> toolbar -> select toolbar keys?

zputnyq commented 2 months ago

So there is an icon set, and also the colors are set to KEY_ICON (when not shifted) and SHIFT_KEY_ICON (when shifted). KEY_ICON is the same color as used for e.g. the delete key. It almost seems like your phone is not reading the icon correctly.

Can you check whether the issue is the same for rounded and holo themes? Oh, and do you see icons for all entries when you go to settings -> toolbar -> select toolbar keys?

I checked it, this issue happens on material & rounded themes. On holo theme, this issue does not exist.

Screenshot_20240708-035159

It's the log for holo theme.

HeliBoard_debug_log_1720408259466.txt

In select toolbar keys section, only 6 entries that doesn't have any icons & they are up, down page up, page down, page start and page end.

Screenshot_20240708-034921 Screenshot_20240708-034928