[Partially enhancement] Odd shift key behavior

[devycarol]

Describe the bug Here's a list of minor 'shift' oddities—mostly related to sliding input:

• Caps lock can be triggered by hovering during sliding input, either by another key's slider or its own
  • Looks like AOSP has this one too. Probably unnoticed because of how silly long that timeout is 🙃
• Sliding input can be triggered when caps lock is on, but it does nothing
  • Similar case when shift is on
• The shift lock long press can trigger when shift lock is already on
  • Especially unexpected if you double-tap and hold for a bit

Expected behavior

• Caps lock shouldn't be activated by the sliding input trail
• Tapping caps lock should immediately switch to lowercase on touch-down, and return to caps lock if a sliding input is performed
  • Manual and auto-shift should have lowercase sliding input and then return to the previous state when done
• Shift shouldn't set the long-press timer when tapped with caps lock on.

App version Debug, 9a273a2

Device: Pixel 5a LineageOS Android 14

[Helium314]

As you already say, those are rather minor oddities. I agree on the expected behavior. Possibly could / should be fixed when overhauling the (imo too complex / convoluted) KeyboardState.

[devycarol]

I'll also add here that when you shift-capitalize a selection into all caps, the all-caps mode is deactivated on typing. It almost certainly shouldn't be.