search

Helium314 / HeliBoard

Customizable and privacy-conscious open-source keyboard
Apache License 2.0
2.45k stars 97 forks source link

Add button popup shadow? #987

Open Roccobot opened 4 months ago

Roccobot commented 4 months ago

I assigned two useful buttons to the action key popup, and I find them very convenient. The only downside is that they are not clearly visible, being each one inside its own separate shape, and with no borders or shadows around.

Would it be possible to make them stand out more?

Action button popups.png

Roccobot commented 4 months ago

@devycarol di you know if it if possible to do this either with an update or by stylizing the buttons through the layout JSON?

Also, replacing the odd 'transparent' popup with the standard one wouls work I guess 🤔

devycarol commented 4 months ago

At this time I think the only way it to set background: "functional"

You lose the accent color but get the more standard shape. Should be stylized like the period key an such.

Roccobot commented 4 months ago

At this time I think the only way it to set background: "functional"

You lose the accent color but get the more standard shape. Should be stylized like the period key an such.

Well, the unspecified type works add well, thanks for the idea! I'd like to keep the accent color, but looks great anyway!

Screenshot_2024-07-20-15-03-50-30_e0eda6d993783efe741dcde5bac07058-picsay.png

Roccobot commented 4 months ago

Actually, with function was even easier: just by swapping function and action colors I can even keep the accent

Popup

Roccobot commented 4 months ago

@devycarol do you think I should keep this open? I found a workaround that is good enough for me, but probably the actual enhancement would still be a nice touch

devycarol commented 4 months ago

I can't say whether I think the action popup style should change, but I do think those default popups should be configurable.

Probably better to lean towards the AOSP style, though I can see a case that's those keys should only have the circle shape with the "no key borders" style, since it's the only one where she key has that shape.