search

Helium314 / Local-NLP-Backend

Yet another network location backend for the UnifiedNLP/microG project
GNU General Public License v3.0
64 stars 4 forks source link

Add "hotspotarriva" to RF emitter blacklist #7

Closed nlpn00b closed 1 year ago

nlpn00b commented 1 year ago

First of all, I want to say that it's great that development is being continued on such a useful tool as Dejavu, very nice

Today I was testing this tool out while traveling with the public transport in the Netherlands, and after exporting the data I found many entries called either HotspotArriva_L_xxxx or HotspotArriva_xxxx where L can be any letter and x can be any number. Arriva is a public transport company and provides moving public internet hotspots in their buses which are named in this scheme.

This case should select it. I also thought of adding && note.startsWith("HotspotArriva"), but I think the chance is very low that this case matches other WiFi networks, so I left it out.

Helium314 commented 1 year ago

Thanks for the contribution!

This case should select it. I also thought of adding && note.startsWith("HotspotArriva"), but I think the chance is very low that this case matches other WiFi networks, so I left it out.

You're definitely right here, case sensitive matching is only necessary if there is a reasonable chance that stationary WiFis with same lower case name exist.