search

Helium314 / SCEE

OpenStreetMap surveyor app for experienced OSM contributors
GNU General Public License v3.0
137 stars 11 forks source link

Add material-Quest for roofs and buildings #443

Open Un1matr1x opened 1 year ago

Un1matr1x commented 1 year ago

Use case

Better and more data especialy for 3d-render in addition to the already existing color-quests "New quest: Roof colour" #428 & "New quest: Building colour" #431

Proposed Solution

Add Quests for Key:roof:material and building:material based on the existing and implemented color-quests

Helium314 commented 1 year ago

Like for the colour quest, I'm not really interested in this information, so this is really low priority for me. Though reading through the wiki: it should be made clear the quest is about the outer / facade material.

Helium314 commented 1 year ago

Essentially this quest should be very simple to implement, most code can be copied and adapted from AddBridgeStructure. Most work would be creating suitable images.

Claurt07 commented 11 months ago

@Un1matr1x Hey, I'm interested in helping this quest to be implemented. But first I wanted to ask you if you had started working on this or were planning to. I have never worked on anything similar but I am willing to give it a try.

Un1matr1x commented 11 months ago

@Un1matr1x Hey, I'm interested in helping this quest to be implemented. But first I wanted to ask you if you had started working on this or were planning to. I have never worked on anything similar but I am willing to give it a try.

Hi @Claurt07 ,

feel free to implement the idea. I unfortunately (or fortunately) did not have as much free time as I had hoped and therefore did not start with the implementation yet.

Helium314 commented 10 months ago

@Claurt07 adding this type of quest is relatively simple, there are several very similar quests you can almost copy, like AddBridgeStructure or AddBikeParkingType. If you have questions, you can ping me or open a draft PR.

ravenfeld commented 2 months ago

@Claurt07 @Un1matr1x Is this still relevant to you? I think I can implement it, but the list is very long. Do you know of any quest that has a filter or anything else? Otherwise scrolling will be mandatory.

Claurt07 commented 2 months ago

Hey @ravenfeld that sounds great! :D It is relevant for me as it would be a very good test as to the relevance of this information for humanitarian aid. As to how it could be implemented, I think it can be done similar to key:surface with the scroll as you mention, and where the options that are "similar" with the low percentage of usage are removed. As of filtering I am not aware, but I would also be interested in learning of quests that include this?

Un1matr1x commented 2 months ago

@Claurt07 @Un1matr1x

Is this still relevant to you?

I think I can implement it, but the list is very long. Do you know of any quest that has a filter or anything else? Otherwise scrolling will be mandatory.

Hi, yes, this would still be relevant for me. Great to see that somebody might take this feature request.

Thanks in advance

ravenfeld commented 2 months ago

@Claurt07 @Un1matr1x

I have opened the 2 PRs for your requests. Do not hesitate to look at the images to suggest others for the choice of materials. I've tried to do my best with the wiki and wikimedia.