Helium314 / SCEE

OpenStreetMap surveyor app for experienced OSM contributors
GNU General Public License v3.0
143 stars 10 forks source link

Quest for selecting `colour` of `bench`es and `waste_basket`s #447

Open Freso opened 1 year ago

Freso commented 1 year ago

General

Affected tag(s) to be modified/added: colour=* Question asked: What is the colour of this bench/waste basket/…?

Checklist

Checklist for quest suggestions (see guidelines):

Ideas for implementation

Element selection: Items with amenity=bench or amenity=waste_basket, possibly also for amenity=waste_disposal, amenity=lounger, amenity=chair, and/or leisure=picnic_table that do not already have a colour=* tag.

Metadata needed: I’m not aware of any per‐country metadata that might be required.

Proposed UI: Same as current "what colour is this" quests.

Helium314 commented 1 year ago

Using the roof / building color style should work. But for each item either a new icon has to be created, or a different color filter should be set. The current color filter needs specifically adapted base icons to work properly.

In the latter case, icons could simply be taken from the pin icons using getPinIcon, and possibly extended using the icons available in presetIconIndex.

HolgerJeromin commented 1 year ago

To be added tag has a useful purpose

Why that?

Freso commented 1 year ago

Why that?

Discussion of the inclusion policy is off‐topic for this issue. Consider opening a new issue (or probably a discussion would be more proper) regarding this question: https://github.com/Helium314/SCEE/issues/new/choose

HolgerJeromin commented 1 year ago

Sorry. I was not clear: What is the useful purpose of mapping/asking color of waste baskets?

Freso commented 1 year ago

My immediate use is for being able to locate/identify them in the landscape, but could also potentially be used for rendering purposes.

rskedgell commented 1 year ago

My immediate use is for being able to locate/identify them in the landscape

Also potentially useful for visually impaired users, particularly where bins are next to each other? Dog waste bins near me are usually red or dark green, normal waste bins any dark colour.

HolgerJeromin commented 1 year ago

I have a bag of dog poo and am unsure where to throw it. I found two bins, but can not see very good (waste bins all look the same, but I can recognize colors!), but my fancy OSM app tells me the dog waste bin is the green and not the black one. Hurray. Problem solved.

🤔