Helium314 / SCEE

OpenStreetMap surveyor app for experienced OSM contributors
GNU General Public License v3.0
141 stars 10 forks source link

Quest(s?) for disabled parking capacity #463

Closed wielandb closed 6 months ago

wielandb commented 11 months ago

General

I would like to implement a quest asking for capacity:disabled=* but I am opening this issue 'cause I am unsure if I should split it into two quests.

Two quests:

One quest:

Pros and cons for doing two quests:

Checklist

Checklist for quest suggestions (see guidelines):

Ideas for implementation

Metadata needed:

none

Proposed UI:

I would copy the UI from a yes/no quest and/or the bicycle parking capacity quest.

Helium314 commented 11 months ago

I would prefer a single quest with quest settings, so the user can choose whether they want the quest to be asked if capacity:disabled=yes. The default disabled message can be used to point the user to the settings. The quest form then could always allow yes/no, and entering a number. yes option should be removed if current tagging is capacity:disabled=yes.

A drawback of this approach is that when the user has set to ask for capacity:disabled=yes and answers with yes, the quest will be asked again immediately. There could be a simple warning about this in the quest settings, or the quest could be hidden automatically so it will not show again. Maybe there could even be a choice in the quest settings, but probably that's not necessary.

wielandb commented 11 months ago

My approach would be the following:

Helium314 commented 11 months ago

Sounds good!

wielandb commented 6 months ago

Fixed in #497