Helium314 / SCEE

OpenStreetMap surveyor app for experienced OSM contributors
GNU General Public License v3.0
141 stars 10 forks source link

New Quest: For which sport is this guidepost intended? (information=guidepost/route_marker) #467

Closed mcliquid closed 9 months ago

mcliquid commented 11 months ago

Reference: https://github.com/streetcomplete/StreetComplete/issues/4758 And: https://github.com/streetcomplete/StreetComplete/issues/5208

General

Affected tag(s) to be modified/added: The common and established tags for sports (like hiking, bicycle, ski, ... Question asked: For which sport is this guidepost intended? The goal is to determine the particular sport(s) for a guidepost or routemarker.

Checklist

Checklist for quest suggestions (see guidelines):

Data from Jan 18: Number of matched nodes in Austria: 14310 Number of matched nodes in Germany: 37408 Number of matched nodes in Switzerland: 7956 Number of matched nodes in United States: 10388

Overpass-Link: https://overpass-turbo.eu/s/1qhA

Ideas for implementation

Element selection:

nodes and 
["tourism"="information"] and
["information"="guidepost"] or ["information"="route_marker"] and
[!"hiking|bicycle|mtb|climbing|horse|nording_walking|ski|inline_skates|running"] and
[!"disused"][!"guidepost"]

There are certainly more sports to filter. Here are the ones that are known to me so far. Please comment if I've missed one!

Concerns:

Proposed UI:

** Possible Quest Filter

nodes with
          tourism = information
          and (information ~ guidepost|route_marker|map)
          and (!guidepost and !disused
          and (
                    !hiking or !bicycle or !mtb or !climbing or !horse or !nording_walking or! ski or !inline_skates or !running
          )
mcliquid commented 11 months ago

@qugebert Would be awesome to have this quest if you have time!

jonpsp commented 11 months ago

I think I would prefer to use "activity" rather than "sport". I do not do any form of sport, but I do use these signs when walking or cycling.

mcliquid commented 11 months ago

A generic question possibility would be: "What is this signpost about?"

qugebert commented 11 months ago

Maybe for maps too? At least in my area, most maps also display hiking/biking routes.

mcliquid commented 11 months ago

I agree, I've added a proposal quest filter in the first post.

Helium314 commented 11 months ago

It often happens that there are several signs for different sports hanging on a pole. Since the ref=* is usually also different, I have preferred to enter the nodes separately. This would not be possible in the Quest. A multiple selection would then have to be stored using a semicolon.

Since the quest is not about ref I think it's fine. When someone wants to add a ref (using a different editor), they can still split the guidepost into multiple nodes.

There are different ways to tag the sport. Either with "hiking=yes" or "guidepost=hiking" or "guidepost:hiking=yes". Based on an evaluation of taginfo, the first one in the list is the most used.

And this is by a huge margin, so I agree on using <sport>=yes

If the user can not say it it definitely needs a "can't say" answer option if it is not answerable to the user.

While it's preferable, I don't think this is absolutely necessary. The quest could be added without such option, and maybe it can be added later based on user feedback (if it occurs to frequently).

Simple image selection or icon selection as in the recycling quest.

A simple text selection like for the seating quest would be fine too.

mcliquid commented 11 months ago

Okay, here is super rough mockup how I imagine the Quest. A simple text selection would also work. Finding harmonious, matching icons for each sport is really a pain.

qugebert commented 11 months ago

I guess simple text selection won't work, as it's single choice but some guideposts are for multiple activities

mnalis commented 11 months ago

Yes, I too think it should be multiple-answer (like in e.g. recycling quest). For example, some routes (and their signposts) are for both cycling and hiking (or might have different summer/winter purposes)

mcliquid commented 11 months ago

I guess simple text selection won't work, as it's single choice but some guideposts are for multiple activities

My mockup is a modified view of the recycling quest, there you can select multiple icons, that's not a problem.

qugebert commented 11 months ago

Okay, here is super rough mockup how I imagine the Quest. A simple text selection would also work. Finding harmonious, matching icons for each sport is really a pain.

So are these icons available in a compatible license? If so, could you please send me these? This would make it much easier for me :)

mcliquid commented 11 months ago

So are these icons available in a compatible license? If so, could you please send me these? This would make it much easier for me

They are all from https://www.svgrepo.com and mostly CC0. The hiker for example: https://www.svgrepo.com/svg/251868/hiker-walk or the Walker: https://www.svgrepo.com/svg/400892/walking (I've faked him some sticks).

Another possible variant would be to take the smoothness UI and add pictures from wikimedia. Hiking for example: https://commons.wikimedia.org/wiki/File:Discovery_Hiker_(5301834691).jpg or Nordic Walking: https://commons.wikimedia.org/wiki/File:Nordic_Walking_is_enjoyed_by_all.jpg

Or taking Unicode Emojis like https://emojipedia.org/hiking-boot

Helium314 commented 11 months ago

I guess simple text selection won't work, as it's single choice but some guideposts are for multiple activities

Making a form that allows multiple selections should be simple. But the recycling-UI based version already looks really good in my opinion.

I'm somewhat opposed to adding photos when it's not necessary. Images already take more than 50% of the APK size, that fraction will likely increase anyway.

mnalis commented 11 months ago

If there is no specific sport displayed on the guidepost, there is guidepost=simple in the wiki: https://wiki.openstreetmap.org/wiki/Tag%3Aguidepost%3Dsimple

Would that be provided as a regular answer (with what picture? questionmark icon?) or as other answer?

mcliquid commented 11 months ago

Would that be provided as a regular answer (with what picture? questionmark icon?) or as other answer?

We must realistically say that no matter where this answer is placed, it will be the answer for all those who do not know what to fill in. Probably not in the SCEE context, but who knows. There is a simple "to the citycenter" sign: It's not really "hiking" nor "bicycle" related - than it's simple. You now the crazy coloured "world guideposts" which guides you 5248km to Paris, 8475km to Capetown and so on? --> simple There's just a big guidepost with "ENTRANCE" and an arrow --> simple

For this reason, I personally would rather put it under Other Answer.

mcliquid commented 10 months ago

@qugebert Did you already started here with something? Otherwise I would start this week with an draft :)

qugebert commented 10 months ago

No, nothing done yet.