Helium314 / SCEE

OpenStreetMap surveyor app for experienced OSM contributors
GNU General Public License v3.0
141 stars 10 forks source link

New Quest: How is the trail visibility on this path? (`trail_visibility`) #478

Closed mcliquid closed 10 months ago

mcliquid commented 11 months ago

General

Affected tag(s) to be modified/added: trail_visibility Question asked: How is the trail visibility on this path?

Checklist

Checklist for quest suggestions (see guidelines):

Ideas for implementation

Element selection:

ways with (
highway = path
and !trail_visibility
and surface = UNPAVED // maybe only ground, grass, rock, sand etc.
// maybe only ways with sac_scale?
)

Proposed UI: Duplication of smoothness quest with images of the trails from the wiki.

References

https://github.com/streetcomplete/StreetComplete/issues/388

It's a very controversial Tag, but I would leave it to the experts to activate this quest.

Helium314 commented 11 months ago

I would definitely limit the filter to ways with sac_scale and surfaces like ground, rock, dirt, grass and similar. Anything else will likely be visible. Alternatively you could exclude all the paved and some unpaved surfaces, so the quest is also shown without any surface tagged

mcliquid commented 11 months ago

Biggest problem currently: Two pictures are missing in the wiki. Will require research and community feedback first.

mnalis commented 11 months ago

I'd ask only on sac_scale or surface ~ "ground|earth|dirt|soil|grass|sand|mud|ice|salt|snow|rock|stone"; because:

mnalis commented 11 months ago

Also, it would probably make sense to exclude lit=yes from the quest

Helium314 commented 11 months ago

I'd ask only on sac_scale or surface ~ "ground|earth|dirt|soil|grass|sand|mud|ice|salt|snow|rock|stone"; because:

Do you really mean to ask for _sacscale or surface? Then there there must be additional filters, as the quest should absolutely not be asked e,g, for this path. With and instead of or the filter seems fine, plus it's very simple to switch to or for users who want more quests.

HolgerJeromin commented 11 months ago

Then there there must be additional filters, as the quest should absolutely not be asked e,g, for this path.

Your path with surface=asphalt should not match surface ~ "ground|earth|dirt|soil|grass|sand|mud|ice|salt|snow|rock|stone"

Helium314 commented 11 months ago

Surface isn't even checked due to or after sac_scale

HolgerJeromin commented 11 months ago

Sorry, I missed the sac_scale=hiking in your example.

mnalis commented 11 months ago

Do you really mean to ask for sac_scale or surface? Then there there must be additional filters, as the quest should absolutely not be asked e,g, for this path.

Yeah, I actually did mean what I wrote, but I did not envision that some people would apparently put sac_scale=hiking on regular urban asphalt sidewalks (why would they do that, that sidewalk is surely not marked as "T1" and it does not add useful information?! It makes even less sense that adding mtb:scale=0 to all urban cycleways). Oh well. But since they apparently do so, then I'd modify that as:

(sac_scale and sac_scale != hiking) or surface ~ "ground|earth|dirt|soil|grass|sand|mud|ice|salt|snow|rock|stone"

With and instead of or the filter seems fine, plus it's very simple to switch to or for users who want more quests.

That is also valid alternative. It might be little on restrictive side (i.e. not produce much quests), but as you say, users of SCEE can tune it up themselves; it is just a default there. Although if that route is taken, I'd rather just ignore sac_scale tag at all and only look at surface tag.