search

Helium314 / SCEE

OpenStreetMap surveyor app for experienced OSM contributors
GNU General Public License v3.0
141 stars 10 forks source link

Add map_type and map_size quests #482

Closed wielandb closed 10 months ago

wielandb commented 11 months ago

This PR adds two quests:

The values are taken from the wiki pages.

Would like thoughts/comments on the following things:

photo_2023-11-02_21-10-51 photo_2023-11-02_21-10-53

mcliquid commented 11 months ago

Nice quests!

  • Do we need custom icons for the quests? Or is the board_type icon okay?

This would make the Quest much more recognizable?

  • Are the descriptions of the answers okay? Or do we need pictures for understandability?

For me, pictures would be much quicker to recognize for a decision.

wielandb commented 11 months ago

Added quest icons.

wielandb commented 11 months ago

The wiki doesn't really provide images we could use. I would need to find some examples myself if the images are deemed neccecary for merge of this PR.

wielandb commented 11 months ago

Just as a heads-up, after adding the icons, the app builds succesfully but crashes on startup. I have no idea how I did this since I only added the icons, but I would not consider this PR "tested" anymore.

Helium314 commented 11 months ago

Or do we need pictures for understandability?

I think for map_size descriptions are enough, but images would be helpful for map_type.

crashes on startup

It doesn't look like there is an error in your last commit. What does the log say?

wielandb commented 11 months ago

I think for map_size descriptions are enough, but images would be helpful for map_type.

Okay, I'll be on the hunt for some example pictures.

It doesn't look like there is an error in your last commit. What does the log say?

I found the problem. When pulling the latest version from upstream, a new quest with the same ordinal I used was pulled in. Fixed that.

wielandb commented 10 months ago

Added images. photo_2023-11-09_11-07-15

wielandb commented 10 months ago

One image was taken from the OSM Wiki and is licensed under CC-BY. Do we have a file where we name the authors in SCEE?

mcliquid commented 10 months ago

Do we have a file where we name the authors in SCEE?

Here you go: https://github.com/Helium314/SCEE/blob/modified/app/src/main/res/authors.txt

I would suggest this one for the toposcope image: https://commons.wikimedia.org/wiki/File:Melshornet03112006GunnarHeltne.jpg

Maybe also to replace with the one in the wiki.

I've added some missing ones here: https://wiki.openstreetmap.org/wiki/Tag:information%3Dmap

wielandb commented 10 months ago

I've added some missing ones here: https://wiki.openstreetmap.org/wiki/Tag:information%3Dmap

Oh theese are way better than mine! I think I'll use them.

wielandb commented 10 months ago

Images replaced and licenses added. Should be ready for review now.

Helium314 commented 10 months ago

I did not yet test it, but some comments:

wielandb commented 10 months ago
  • could you convert the png images to jpg if there is a reasonable decrease in size?
  • raster images should use density qualifiers, i.e. use hdpi and similar folders for reduced size images, you can compare with images from other quests
  • map_type_1.png is missing in authors.txt
  • MapType appears to use placeholders, e.g. ZERO("0") instead of e.g. TOPOGRAPHIC("tope")

Everything done.