search

Helium314 / SCEE

OpenStreetMap surveyor app for experienced OSM contributors
GNU General Public License v3.0
114 stars 8 forks source link

Update AddBuildingColour.kt #512

Closed ivanbranco closed 4 months ago

ivanbranco commented 4 months ago

Windows are usually transparent, so I think it should be ok to exclude them from the colour quest

Helium314 commented 4 months ago

There is colored glass, which is why building:material=glass is not excluded, see https://github.com/Helium314/SCEE/pull/431#issuecomment-1577402157.

What actually is building:part=window? It has very low occurrence (<1000) and I can't find any documentation.

ivanbranco commented 4 months ago

building:part=carport is excluded, and has even less occurrence than =window. Most of glass is transparent, so there are a lot of quests that cannot be solved. But if you decided so is okay for me.

mcliquid commented 4 months ago

so there are a lot of quests that cannot be solved

building:part=window has only 316 objects worldwide (nodes excluded). That's not that many that remain unsolveable, is it? And did you know that you can change the quest filter yourself? 👍

Helium314 commented 4 months ago

building:part=carport is excluded, and has even less occurrence than =window. Most of glass is transparent, so there are a lot of quests that cannot be solved. But if you decided so is okay for me.

I let @hangy decide on the inclusion of glass buildings (which sort of includes windows), and don't want to simply overrule it now. Personally I don't have a strong opinion on this, building<:part>=window and even building:material=glass affects only a relatively small number of elements.