Helium314 / SCEE

OpenStreetMap surveyor app for experienced OSM contributors
GNU General Public License v3.0
114 stars 8 forks source link

created quests for lgbtq people #518

Open jan-leila opened 4 months ago

jan-leila commented 4 months ago

Leaving as a draft for now because I dont have any icons for things yet and im waiting for some friends to translate some of the text for me, but other then that PR is almost ready to go

Added:

Still needed:

relevant wiki page: https://wiki.openstreetmap.org/wiki/Key:lgbtq

Helium314 commented 4 months ago

lgbtq:signed does not have any uses according to taginfo. I would prefer merging the access and the signed quests, so the access quest would just allow a not signed answer.

jan-leila commented 4 months ago

as far as I can tell there isnt really any used tag that could be used to mark the quest as completed if a place just has nothing posted

jan-leila commented 4 months ago

also the other goal with separating out the quests like that was to hide the complexity of picking what kind of signage behind the knowledge of their actually being signage

jan-leila commented 4 months ago

and also a "no" on the signage does not mean the place is in that neutral state it just means its not apparent when you walk by, I wouldn't want places that on their website say they are lgbtq=primary but dont have any sings displaying that in person getting marked at the neutral state

Helium314 commented 4 months ago

as far as I can tell there isnt really any used tag that could be used to mark the quest as completed if a place just has nothing posted

SCEE guidelines are more loose than for SC, there are already several quests that don't fulfill no unanswerable quests.

also the other goal with separating out the quests like that was to hide the complexity of picking what kind of signage behind the knowledge of their actually being signage

With the downside of pushing a completely new tag exclusively via SCEE. Also that tag likely doesn't fulfill the only guideline that is still strict as it does also affect non-users (no spam).

jan-leila commented 4 months ago

SCEE guidelines are more loose than for SC, there are already several quests that don't fulfill no unanswerable quests.

gotcha, ill remove it then, do you have a example you can point me to on how we go about hiding the quest locally when there isnt a clear answer?

Helium314 commented 4 months ago

do you have a example you can point me to on how we go about hiding the quest locally when there isnt a clear answer?

Either you use other answers -> can't say -> hide, or use the quick hide button that can be enabled in Settings / UI, or if you want to bake it into the quest you can add some UI element or other answer that calls osmQuestController.hide(questKey as OsmQuestKey) (get the controller using private val osmQuestController: OsmQuestController by inject()

Helium314 commented 4 months ago

I guess putting it into the form makes most sense, as (around here) it would be the most common answer. Unfortunately hiding is a rather bad thing when hiding is the "answer" most of the time, as it means the quest will still be shown to other users... but given that SCEE only has ~500 active users (see here), there is hope that 2 users in the same area is a rather rare thing.

mnalis commented 3 months ago

Unfortunately hiding is a rather bad thing when hiding is the "answer" most of the time

Yeah, quests with that issue that becomes very tedious very fast in my experience (usually resulting in me disabling the quest in most of my presets). For things where majority of answers are "not signed", perhaps an SCEE Overlay might be better solution than the Quest? That would seem to address that very problem.

(Relatedly, also people might be interested in creating LGBTQ+ theme for https://mapcomplete.org/ as that creates both a browseable map and a specialized quest; somewhat similar to how SC(EE) Overlays work, but available in regular desktop&mobile browsers)

Helium314 commented 3 months ago

Another way would be using a server (but considerably more work for setting up the server). E.g. Osmose quests are "hidden" for everyone when you answer it's a false positive.

Helium314 commented 3 months ago

I'd like to summarize what is still to be done here

Anything else? Translations are mentioned, but can be done later with Weblate.

jan-leila commented 1 week ago

Okay I think besides icons and translations things are good on my end, not sure what to do about those two items though being im only a native English speaker and am not good with design software

jan-leila commented 1 week ago

icons needed are as follows:

LGBTQ access quest icon for pin on map LGBTQ access quest banned icon LGBTQ access quest welcome icon LGBTQ access quest primary icon LGBTQ access quest only icon LGBTQ access quest unknown icon

LGBTQ Gender Specialization Quest icon for pin on map

LGBTQ Transgender Specialization Quest icon for pin on map

Helium314 commented 1 week ago

LGBTQ access quest banned icon LGBTQ access quest welcome icon LGBTQ access quest primary icon LGBTQ access quest only icon LGBTQ access quest unknown icon

You could avoid those by using a AListQuestForm like the seating quest

Some possibly dull but working idea would be use the common flag colors (rainbow / transgender) for the specialization quests, maybe with some additional icon. The access quest could use something like https://wiki.openstreetmap.org/wiki/File:AllPeopleSticker.jpg

Okay I think besides icons and translations things are good

Translations are not needed, they will be added by other users using Weblate.

btw tempHide does only hide the quest until the next change of the element, or until the surrounding area is cleared from cache. A "normal" hide seems more appropriate to me.

jan-leila commented 6 days ago

I considered using a list form but I would like to have the examples, but maybe sort term here just to get the feature existing I use a list form and we can work on getting the other icons together some other time. (Ill switch it if we get the icons for everything else made first)

and ill switch the temp hide