Closed wielandb closed 2 months ago
I am okay with re-adding it though, given that it is explicitly tagged as being signed that way, i.e. adding bicycle:signed=yes
(sidewalk:<side>:bicycle:signed=yes
respectively) too in that case and making it clear to the user that this option should only be chosen when there is a sign about that.
https://github.com/streetcomplete/StreetComplete/issues/4913
If this was implemented upstream instead of SCEE, a lot more users will profit of this.
Nice to hear! I will open a PR upstream. 🙂
I did a quick review of the PR in the current state. Some comments:
bicycle:signed=yes
is added, when choosing a different option, it also has to be removed again
Most of the code for this was already implemented but as of the discussion in https://github.com/streetcomplete/StreetComplete/issues/2276 and subsequent discussions it was removed in StreetComplete because if bicycles are allowed on the sidewalk may need expert knowledge depending on the legislation, and it may not be surveyable on-the-ground easily. Since requireing expert knowledge is no problem in SCEE, I have (re)implemented the functionality here.
sidewalk:[side]:bicycle=yes
sidewalk:[side]:bicycle=yes
bicycle=
, since choosing it now means that the user intents there to be no statement about bicycles