Helium314 / SCEE

OpenStreetMap surveyor app for experienced OSM contributors
GNU General Public License v3.0
114 stars 8 forks source link

Add the possibility to explicitly tag sidewalks as allowed for bicycles #530

Closed wielandb closed 2 months ago

wielandb commented 3 months ago

Most of the code for this was already implemented but as of the discussion in https://github.com/streetcomplete/StreetComplete/issues/2276 and subsequent discussions it was removed in StreetComplete because if bicycles are allowed on the sidewalk may need expert knowledge depending on the legislation, and it may not be surveyable on-the-ground easily. Since requireing expert knowledge is no problem in SCEE, I have (re)implemented the functionality here.

photo_2024-04-04_10-41-28 photo_2024-04-04_10-41-53
westnordost commented 3 months ago

I am okay with re-adding it though, given that it is explicitly tagged as being signed that way, i.e. adding bicycle:signed=yes (sidewalk:<side>:bicycle:signed=yes respectively) too in that case and making it clear to the user that this option should only be chosen when there is a sign about that.

https://github.com/streetcomplete/StreetComplete/issues/4913

If this was implemented upstream instead of SCEE, a lot more users will profit of this.

wielandb commented 2 months ago

Nice to hear! I will open a PR upstream. 🙂

westnordost commented 2 months ago

I did a quick review of the PR in the current state. Some comments: