search

Helium314 / SCEE

OpenStreetMap surveyor app for experienced OSM contributors
GNU General Public License v3.0
114 stars 8 forks source link

Merge all SCEE ref quests into one #532

Closed FloEdelmann closed 2 months ago

FloEdelmann commented 2 months ago

Fixes #531. Since #529 has not been released yet, removing it should not be a problem.

For reviewing, it makes sense to go through each commit one-by-one, since diffs are displayed for renamed files then.

Helium314 commented 2 months ago

Thanks, I think this is fine. I didn't test, but I assume the filter works correctly? Asking because I'm not sure about evaluation of "a or b and c or d and e" style without parentheses.

@qugebert are you ok with this modification / removal of the guidepost ref quest?

FloEdelmann commented 2 months ago

I assume the filter works correctly?

Yes, I tested it.

I'm not sure about evaluation of "a or b and c or d and e" style without parentheses

and takes precedence over or, so this is correct. This is also how other quests do it:

https://github.com/Helium314/SCEE/blob/9522acc6e345d78516fd95f1cd2efff854777605/app/src/main/java/de/westnordost/streetcomplete/quests/existence/CheckExistence.kt#L42-L43

... and Tobias prefers this style, as less parentheses is less visual clutter to parse mentally.

qugebert commented 2 months ago

@qugebert are you ok with this modification / removal of the guidepost ref quest?

Yes