search

Helium314 / SCEE

OpenStreetMap surveyor app for experienced OSM contributors
GNU General Public License v3.0
114 stars 8 forks source link

Disabling overlay does not automatically remove coloring #545

Open mnalis opened 1 month ago

mnalis commented 1 month ago

How to Reproduce

  1. enable overlay (either via side quick-overlays, or via regular overlay button at the top)
  2. disable overlay (click again on right side quick-overlays, or select None in regular overlay button
  3. notice the Overlay coloring remains, even if overlay is disabled
  4. pan or resize map a little
  5. only now Overlay coloring is removed

Expected Behavior The overlay coloring should be removed at step 3.

Does it happen in normal StreetComplete? No, SC 57.4 works as expected

Versions affected SCEE 57.4, Android 14

mnalis commented 1 month ago

Video

https://github.com/Helium314/SCEE/assets/156656/769198d7-a9af-4f5b-92fd-20f90e3f260a

Helium314 commented 1 month ago

Can't reproduce, does it always happen? (anyway, I'm probably not going to do anything here as MapLibre is coming)

mnalis commented 1 month ago

Can't reproduce, does it always happen?

Ah... It seems no, not always.

Although that day, even when closing and reopening app several times, it seemed it was being 100% reproducible. Today I tried and it seems it only happens when location is off, but works ok when it is on. And now after several tries it seems it works even when location is off. :confused:

I know MapLibre might change a lot of those things; I've reported it as (at the time) it seemed to always happen in SCEE and never in SC; and I have no idea how long-term that MapLibre transition (being a huge effort) is supposed to take (weeks? months? years?)

(anyway, I'm probably not going to do anything here as MapLibre is coming)

Sure, no worries. I'll try to reproduce more thoroughly when MapLibre version is released, then.

Helium314 commented 1 month ago

(weeks? months? years?)

There is mostly minor stuff left, and some bug in MapLibre that sometimes stop overlay symbols from being displayed. (though the migration will be a setback for SCEE, I will likely remove a bunch of map-related features and slowly re-add them over time)

only happens when location is off

That actually indicates some missing call to draw the map (the location causes frequent redraw due to compass updates). I remember I fixed this in SC a while ago, maybe missed some additional place in SCEE.

ravenfeld commented 9 hours ago

@mnalis You always reproduce, I don't reproduce in 58.1

mnalis commented 1 hour ago

You always reproduce, I don't reproduce in 58.1

Neither could I always reproduce, see this update in https://github.com/Helium314/SCEE/issues/545#issuecomment-2125558016

In any case, this is blocked until MapLibre version is released, as it makes little sense to invest time debugging code which will be replaced very soon.