Helium314 / SCEE

OpenStreetMap surveyor app for experienced OSM contributors
GNU General Public License v3.0
142 stars 10 forks source link

Add Quest: building:material #569

Open ravenfeld opened 3 months ago

ravenfeld commented 3 months ago

I'm going to split the request in 2. https://github.com/Helium314/SCEE/issues/443

Creating a quest to add building material

Screenshot_20240703_105109

HolgerJeromin commented 3 months ago

Metal, steel and tin is a bit confusing. But yeah, all are in use...

ravenfeld commented 3 months ago

Yes, I said to myself that I couldn't select a value. Maybe change the message to indicate that only experts can use it?

Or other photos but I myself am not an expert on the subject.

HolgerJeromin commented 3 months ago

Perhaps drop steel and tin and let metal as the only value.

ravenfeld commented 3 months ago

@Claurt07 @Un1matr1x

What do you say to these tags?

I like having the choice, especially when I know the subject well. In this case, it would mean that contributors are being forced to use metal, which may or may not be the case. But I'll let those who contribute to these values tell us what they need.

mcliquid commented 3 months ago

metal is a generic term for a variety of elements and alloys with metallic properties. steel is a solid alloy of iron and carbon. steel is defined in the norm "EN 10020". tin is a soft, silvery-white metal. tin forms verdigris (green mould), which is often found on church roofs (Example).

As a comparison to surface: metal behaves more or less like paved while steel, aluminium or tin are more specific.

Claurt07 commented 3 months ago

@mcliquid thanks for shedding some light on that -- I have to acknowledge I was not clear on the distinction of some of these. Keeping at least metal or steel and tin (or the three) are good for my use case, as we provide a way for people to specify a form of metal that is generic and one that might be more "vulnerable" than the rest.

@ravenfeld the rest looks good to me! the images are also very illustrative. I only have another question, should Mud and Adobe be combined and leave only Mud? It is called Adobe where I am from in LATAM, but I wonder if it is not too specific.

HolgerJeromin commented 3 months ago

@mcliquid You are right, but the target audience is probably not able to differ steel from other metals...

mcliquid commented 3 months ago

@HolgerJeromin I definitely agree with the target group of StreetComplete. But here we are talking about SCEE - the StreetComplete Expert Edition, right? My understanding of this version is that we can offer quests here that can go beyond the normal expected level of knowledge, as we can expect the specific target group to intentionally disable such quests (each of which comes with an individual warning) if they are unable to answer them.

Helium314 commented 3 months ago

I did not have a look at basically anything yet, but please massive reduce image size. This PR alone is adding ~4 megabytes to app size.

Also not sure about the general style when I look at the images. Some of the tags appear to be categories, e.g. metal -> tin+steel, or stone -> sandstone.

Btw what is mirror supposed to mean? "This building is made of mirrors"?

ravenfeld commented 2 months ago

@mcliquid @Claurt07 @Un1matr1x Can you help me find more meaningful images? I've looked on the wiki and on wikimedia common. As this is not a quest that I would undertake and as it is taking me a long time to find images, I would like to ask for your help. Thank you for your help.

mnalis commented 2 months ago

TL;DR: perhaps go just with metal (or metal and copper), ignoring other metal-detailed answers.


tin forms verdigris (green mould), which is often found on church roofs (Example).

Actually, it is copper salts that produce that green patina, not tin. Tin is major component of solder, and tin foil is what we used to use to make tin foil hats to protect us from government (or alien) mind-reading devices (or to wrap food) :smiley: - although it has mostly been superseded by aluminium foil nowdays, but name stuck.

As for building material, while I generally prefer detailed answers to be available in SCEE, I'm not so sure here.

Basically, only copper is distinctive, other metals not so much. So I'd be fine with just metal (or metal and copper, but that is bound to have people asking questions "why is there copper, and not tin" etc).


Most people (who are not material scientists or are unwilling to scratch the surfaces to determine what it is) will be hard pressed to tell the difference between corrugated galvanized iron (sometimes called "wriggly tin" to add to the confusion, even if Zinc is used for galvanization), steel that has been coated with Zinc-Aluminium, iron/steel coated with thin layer of tin (also known as "Tinplate"), various aluminium alloys (aluminium+manganese, aluminium+magnesium etc.) and steel coated with alloy of lead and tin (also called Tinplate colloquially, but more precisely Terne, even if in original coating there was order of magnitude more lead then tin; but the coating is not load bearing (majority) material anyway).

The use of actual tin as building/roof material is not what one would find in real life, it is too structurally weak. Also, "Tinplates" often do not contain tin at all (and even when they do, it is in micro amounts only for coating, main load bearing material usually being steel; but there are also various aluminum alloys which people might incorrectly call by such "tin" names because of history - just like Tinfoil hat above)

mcliquid commented 2 months ago

So I'd be fine with just metal

I agree, let's start simple and pick only the significant values. You can always extend a quest later!

ravenfeld commented 2 months ago

What do you want me to display then?

mnalis commented 2 months ago

What do you want me to display then?

Drop steel, tin, copper, metal_plates (but retain generic metal)

mnalis commented 3 weeks ago

As far as I can see, those are several issues mentioned so far that prevent this PR: