search

Helium314 / SCEE

OpenStreetMap surveyor app for experienced OSM contributors
GNU General Public License v3.0
154 stars 12 forks source link

Ignore access=private for all quests #607

Open Atrate opened 3 months ago

Atrate commented 3 months ago

Use case

I don't really get why the original SC ignores quests for things tagged access=private. In most cases it's e.g. a service road I can already see so I can map the surface and other quests without a problem and without tresspassing.

Proposed Solution

While SCEE allows to edit the overpass query for individual quests, with 216 quest types and counting it has become unfeasible to remove the access=private filters on all of them. It'd be nice if there was a toggle in the settings that did it for all of them simultaneously.

Helium314 commented 3 months ago

It's also a lot of work for me (though it seems that less than 100 quests have a private filter), and with questionable benefit. I'm not going do implement this, but I'm willing to accept a PR under the condition that it minimizes the chances of merge conflicts when SC filters are changed. (I'm also not going to update it when new quests are added to SC)

mnalis commented 3 months ago

Yes, it would seem like too much work and maintenance to me too (unless it was some smart-regexp option which searched for and access ~ no|private and similar strings in element selector strings and replaced them with empty strings (but then again such generic approach might also backfire).

What I'm more worried about is that removing private restrictions should not IMHO apply to all quests. Sure, I can often see surface, sidewalk and cycleway on that access=private road, so removing private restrictions there might be useful in some cases... But smoothness is harder (well, at least for my eyesight) - especially if that road segment is not rather short, I cannot reliably tell exact surface quality on its whole length (without walking it down)

Even more problematic are quests like drinking_water=* on that access=private well? Or internet_access=* in that access=private chalet? Or payment:* on that access=private club? I don't think can answer those (without getting in problems).

Helium314 commented 3 months ago

I don't think can answer those (without getting in problems).

Though maybe you know the right people and can thus legally visit some of those locations...

But actually I think everything would be fine, as you have to explicitly enable the setting. So you should know that quests can be asked for places you're not allowed to access.