search

Helium314 / SCEE

OpenStreetMap surveyor app for experienced OSM contributors
GNU General Public License v3.0
151 stars 12 forks source link

Expert Mode off, blocks certain quests from being activated #612

Open RubenKelevra opened 2 months ago

RubenKelevra commented 2 months ago

Currently certain quests cannot be activated if the switch "Expert Mode" in the settings is not on.

Given that this is Street Complete Expert Edition, I'm not sure it needs a switch to turn on "Expert Mode".

But this aside, since those quests are shown like any other quest, but just not react to turning them on - without any further hint why this is the case, the UI/functionality does not follow the Principle Of Least Astonishment.

I recommend either

How to Reproduce See https://github.com/Helium314/SCEE/issues/611

Expected Behavior The UI should follow the Principle Of Least Astonishment.

Does it happen in normal StreetComplete? Nope

Versions affected Android 12 SCEE 58.21 and 59.0-alpha1

Helium314 commented 2 months ago

Given that this is Street Complete Expert Edition, I'm not sure it needs a switch to turn on "Expert Mode".

In my opinion it does. If you check notes created with SCEE, you will often notice users that are pretty new to OSM creating notes that show those are not secondary accounts of experienced users. Those who don't even go to settings essentially will have SC, and those who do will see an explicit warning with the unexpected "understood" instead of "ok" button before they can use the more dangerous capabilities of SCEE.

mnalis commented 2 months ago

add a popup if the user tries to enable those disabled quests

... is the only one that would improve situation, IMHO.

Some message there (e.g. "Those quests cannot be enabled unless expert mode is enabled, because they might require intimate knowledge of OSM workings in order not to damage data or otherwise produce unwanted results" or something similarly scary) when clicking on disabled quest might be helpful to explain why those are disabled...

RubenKelevra commented 2 months ago

Given that this is Street Complete Expert Edition, I'm not sure it needs a switch to turn on "Expert Mode".

In my opinion it does. If you check notes created with SCEE, you will often notice users that are pretty new to OSM creating notes that show those are not secondary accounts of experienced users. Those who don't even go to settings essentially will have SC, and those who do will see an explicit warning with the unexpected "understood" instead of "ok" button before they can use the more dangerous capabilities of SCEE.

I might not have been clear earlier: I actually like that you can toggle advanced editing features like tags. I was just wondering if labeling it ‘Expert Mode’ when you’ve already installed the expert edition is necessary. It feels a bit redundant.

RubenKelevra commented 2 months ago

add a popup if the user tries to enable those disabled quests

... is the only one that would improve situation, IMHO.

Some message there (e.g. "Those quests cannot be enabled unless expert mode is enabled, because they might require intimate knowledge of OSM workings in order not to damage data or otherwise produce unwanted results" or something similarly scary) when clicking on disabled quest might be helpful to explain why those are disabled...

Yeah that's my favorite solution, too.

HolgerJeromin commented 2 months ago

I was just wondering if labeling it ‘Expert Mode’ when you’ve already installed the expert edition is necessary. It feels a bit redundant.

We are the experts of the experts :-D

RubenKelevra commented 2 months ago

I noticed that every single quest which is part of the expert edition got a prompt of some kind if you activate it.

Maybe we could remove them? 🤔

I mean the user already activated that he/she wants to use the expert features, I don't think there's a need to remind the user on every quest they activate that they choose to do so.

rusty-snake commented 2 months ago

Some have just the default message, but others show additional information why it is an expert quest. I find this very useful.

RubenKelevra commented 2 months ago

I don't. It's just annoying:

https://github.com/user-attachments/assets/efd38f2b-373c-46a6-8cff-ffddb99604de

rusty-snake commented 2 months ago

Your usecase it to enable all SCEE quests?

RubenKelevra commented 2 months ago

Yeah, hat to reinstall an older version to continue to map, as the Alpha is currently unusable.

But that's an issue on every new profile for Quests you create. It's so annoying that I usually clone the "all" preset and then rather disable than enable quests.

Its such a nuisance.

There's zero advantage of having all those pop-ups, it just makes the app harder to use.

rusty-snake commented 2 months ago

Well I enable only selected SCEE quest where I want to contribute data, have knowledge in the tagging of this topic. Having all enabled is just to spammy in my area and I don't want to mess-up the database because I forgot that that "foo" is a SCEE quest that can only be answered on 70% of the objects it shows on.

RubenKelevra commented 2 months ago

And? 🤔

I still don't see an advantage of annoy user with useless pop-ups.

mcliquid commented 2 months ago

I can understand the frustration, but the question is, how often does this happen? In my opinion, only the very first time. And then you have to assume that the user has never used SCEE before. In that case, the pop-ups are necessary to draw attention to the fact that the individual quests are not easy to answer and should be chosen carefully.

As soon as you have activated the desired quests after the first installation, the problem no longer occurs. You can make gradations in the individual presets and export everything as a backup at the end in case you have to reinstall the app.

rusty-snake commented 2 months ago

After all I'm not the person how decides this. I've said that I would like to keep them. No reasons to further discuss this. If there is someone how you need to convince it's not me.

michaelblyons commented 1 month ago

You already have a way to show "disabled by default" and "disabled in {your region}" which can both be shown for the same quest. Please also add a "disabled without expert mode" (wording could be better) one, too

Helium314 commented 1 month ago

You already have a way to show "disabled by default" and "disabled in {your region}" which can both be shown for the same quest. Please also add a "disabled without expert mode" (wording could be better) one, too

That's the only suggestion so far that should be simple to implement and not have unwanted side effects.