search

Helium314 / SCEE

OpenStreetMap surveyor app for experienced OSM contributors
GNU General Public License v3.0
150 stars 11 forks source link

background type switch gone #629

Open RubenKelevra opened 2 months ago

RubenKelevra commented 2 months ago

Maybe I'm overlooking something, but is the background type switch now gone?

How to Reproduce Open settings

Expected Behavior Have a background switch, like before

Does it happen in normal StreetComplete? Nope, SC doesn't have the feature

Versions affected Android 12 SCEE Version 58.22

pkoby commented 2 months ago

I have v59.0-alpha2, but if you're looking for the toggle for aerial/map background, in Settings, turn on Expert mode, click UI, then turn on Quick Settings Button. The cog button then has the background switcher.

mnalis commented 2 months ago

click UI, then turn on Quick Settings Button. The cog button then has the background switcher.

Works for me in SCEE 58.22 (on Android 6.0.1) too :+1: (and expert mode is not even needed).

Helium314 commented 2 months ago

The switch was part of SC, and wasn't re-added when the settings were migrated to compose

RubenKelevra commented 2 months ago

The switch was part of SC, and wasn't re-added when the settings were migrated to compose

Why not readd a drop-down under Display in the settings, to keep it consistent?

There's no indication of this change in the changelog, right? So I wasn't expecting that the feature of having aerials is just "gone".

Helium314 commented 2 months ago

Changelog is only for SCEE, and I will not start listing SC changes in there even if the affect SCEE in different / unintended ways

Why not readd a drop-down under Display in the settings, to keep it consistent?

I don't think a drop-down would be consistent for an essentialy boolean setting, but I don't care enough to demand changes if a setting was added like this in a PR.

mnalis commented 2 months ago

I don't think a drop-down would be consistent for an essentialy boolean setting

RubenKelevra commented 2 months ago

I don't think a drop-down would be consistent for an essentialy boolean setting

I would love to add the Aerials released for OSM use by my state. They are like 10 times better resolution than Esri and well aligned with GPS positions.

But it's always good to be able to switch back and forth, as some aerials are better than others for some areas.

A good example for this is tree positions which are easier to spot on winter images, where trees cast long shadows and have nearly no leaves.

Maybe allow for custom entries to be added and just shown in the list?