search

Helium314 / SCEE

OpenStreetMap surveyor app for experienced OSM contributors
GNU General Public License v3.0
154 stars 12 forks source link

Destinations quest filter too restrictive #636

Open RubenKelevra opened 2 months ago

RubenKelevra commented 2 months ago

I've noticed a couple of times now that the destination quest isn't always showing up when there are signage to map.

How to Reproduce Currently the filter seems to be along the lines of "if there's an intersection with a road not on the white list of road types, don't show quest.

So if there's a T intersection of secondary roads, it will show up.

If the T intersection of secondary roads also got a residential road, shooting off, making it an X intersection, the quest doesn't show up.

Expected Behavior I think the filter is too restrictive, as intersections where a major road does a turn or there's a T intersection between two major roads, there's signage to map.

It doesn't matter if there's a residential road also connected to the intersection.

So maybe the filter can be lighten up to always show the quest on intersections if there's a major road, except if the major road does go straight - and no other major road connects to this intersection?

Can we filter for degrees of turn on a road at an intersection?

Does it happen in normal StreetComplete? No, it doesn't have the quest

Versions affected Android 12 SCEE 58.22

Helium314 commented 2 months ago

If implemented, this change must be customizable. I remember the default settings were seen as not restrictive enough by other people. But instead of having potentially convoluted logic I'd suggest to implement a destination overlay, as was already discussed in #419

RubenKelevra commented 2 months ago

@Helium314 was this seen as not restrictive enough in SC or SCEE? 🤔

As we got a lot of new users in SC this makes perfect sense, in SCEE a not so restrictive filter is fine I think.

I mean simply a button "nothing is posted" and we add "none" there would be fine by me. 🤷‍♂️

Btw: I noticed that the text could be slightly improved. I think it makes sense to point out that destinations should not include road refs. We have a lot "here's the way to road A1" signs in Germany, without any destination posted. And I wasn't aware that the specification is, to only add named destinations.

So I added some wrong data in the beginning :/

Helium314 commented 2 months ago

was this seen as not restrictive enough in SC or SCEE?

In SCEE, SC doesn't even have that quest.