Adding quest: Caravan site type

Helium314 / SCEE

OpenStreetMap surveyor app for experienced OSM contributors

GNU General Public License v3.0

154 stars 12 forks source link

Adding quest: Caravan site type #643

Closed mcliquid closed 2 months ago

mcliquid commented 2 months ago

Fixes #641

Icon could be improved, but should work
Strings could also be improved, but they should work out
Quest was tested

mcliquid commented 2 months ago

FYI: I've fixed the German Term ("Wohnwagen-Stellplatz") for the English Term "RV Park" to "Wohnmobil-Stellplatz".

Helium314 commented 2 months ago

Looks fine! I'll have a look at how the icon looks in the app a bit later, judging by the SVG it should be fine though.

Strings should be ok, only thing I noticed is that harbour is British spelling, while the "default English" in Android is supposed to be the US variation.

mcliquid commented 2 months ago

Thanks for the quick feedback! I've changed the string to US English.

mcliquid commented 2 months ago

should it perhaps have:
override val achievements = listOf(OUTDOORS)
(or some other achievement?)

Can I add to that - I wasn't aware that SCEE quests can also get achievements.

goldfndr commented 2 months ago

One more minor edit: "wineyards" should be "vineyards". (I've corrected the wiki page.)