Helium314 / SCEE

OpenStreetMap surveyor app for experienced OSM contributors
GNU General Public License v3.0
139 stars 11 forks source link

Custom Thing-overlay entries #649

Open ahstro opened 1 week ago

ahstro commented 1 week ago

Use case

I wanted to map some advertising screens, of which there are far too many, but adding them properly requires me to add "Digital screen" with the Thing-overlay, and adding a whole heap of tags manually. Having the ability to add custom entries available in the Things-overlay would smooth this process out.

Proposed Solution

I propose adding a setting somewhere under "SCEE settings" which keeps a list of custom things, where a thing is an icon, a name, and a set of tags, similar to how quests are customizable.

mnalis commented 1 week ago

I wanted to map some advertising screens,

Probably a better idea would be to suggest such tagging to be included in id-tagging-schema.

That way, not only SCEE would benefit, but also StreetComplete, EveryDoor, Vespucci, iD, and many other projects that use it!

You could even make PR yourself if you want to speed it up, it is a simple JSON text file (see e.g. advertising=totem example)

I propose adding a setting somewhere under "SCEE settings" which keeps a list of custom things, where a thing is an icon, a name, and a set of tags, similar to how quests are customizable.

I can see some use of "Custom things", but only for very localized and specialized things which are not present nor popular worldwide (so would probably not get included in id-tagging-schema). But for such worldwide common things such as "advertising screens", I'd definitely recommend to go the id-tagging-schema way mentioned above.

Also, while there is some use for such "Custom things", UI for maintaining that would seem rather complex... Perhaps easier to implement idea idea (if such "custom things" were to be supported) would be to parse some common format for those, like custom JOSM presets (Vespucci at least seems to have such parser already, so perhaps it could be borrowed). That way all the preparing of such custom things is offloaded to the (expert) user, and SCEE only has to parse the result. But still, even that is not easy and would need to written, and with ongoing transition to MapLibre and iOS support, developer resources are spread rather thin (and likely will be for some time)...

Helium314 commented 1 week ago

and adding a whole heap of tags manually

When you use the long-press add POI functionality, you will get a redo button in the tag editor, so you only need to do the changes once.

Otherwise, I don't intend to add functionality that allows adding custom things, because the search uses the https://github.com/westnordost/osmfeatures/ library, and I don't want to maintain a fork of it.