search

Helium314 / SCEE

OpenStreetMap surveyor app for experienced OSM contributors
GNU General Public License v3.0
154 stars 12 forks source link

Ask ref for golf holes #665

Closed FloEdelmann closed 2 months ago

FloEdelmann commented 2 months ago

see https://wiki.openstreetmap.org/wiki/Tag:golf%3Dhole

but given that most golf courses with this micromapping probably already have refs for the holes, it's not worth an upstream StreetComplete quest

mnalis commented 2 months ago

but given that most golf courses with this micromapping probably already have refs for the holes,

taginfo says that 94% of golf=hole indeed do have a ref=*, but that still leaves about 13k of them without ref...

it's not worth an upstream StreetComplete quest

well, perhaps, but perhaps not, 13k is not that little... :shrug:

But yeah, since SC does not have general_ref quest (yet), so it would need whole new quest there, it is probably fine to just add extra match in this SCEE-specific quest.

_(That being said, I generally prefer that things are tried in StreetComplete first if they have any chance of being accepted. Even if it is more work and waiting, but that pays off a lot more in the future - as every change that goes into upstream SC instead of into SCEE reduces future maintenance load here. But as said above, since SC does not have general_ref quest at all, it is not as big an issue)_

Helium314 commented 2 months ago

Possibly it could be a SC quest, but I somewhat doubt the usefulness of adding ref to a golf hole. For the generic ref quests it's certainly a good addition.