Helium6CRES / he6-cres-spec-sims

A python package to simulate cres data for the 6He CRES experiment at CENPA (University of Washington).
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Cleanup/reorganization #7

Closed rjtayl closed 3 months ago

rjtayl commented 3 months ago

We've made the major changes to how spec_sims was organized that I wanted. There may be some cleanup and improvements we could still make but I believe all the changes that would have made parallel development and merges difficult have been completed.

Major changes:

buzinsky commented 3 months ago

Looks good to me - produces the same results as before I think more classes (e.g. Beta, or Event) to collect these variables (center_theta, z_max, radius, energy...) would be nicer than passing many arguments I also see this as lower priority. We have the power to deal with merge conflicts, should they happen

rjtayl commented 3 months ago

Yeah I agree we should eventually make those classes, after the more urgent features we've discussed.